[hermes] Remove diagnostic path mapping from shadow copy

[joshlf]

---

This PR is on branch hermes.

• 　  [WIP] Agent #3050
• 　  [WIP] #3049
• 　  [hermes] Invoke Aeneas #3048
• 　  [hermes] More aggressively test hidden item rejection #3047
• 　  [hermes] Reject annotated items in blocks #3046
• 　  [hermes] Warn on #[cfg_attr(..., path = "...")] #3045
• 　  [hermes] Don't pass overly-long arguments to Charon #3044
• 　  [hermes] Harden against weird symlink layout #3043
• 　  [hermes] Clean up after removing shadow crate support #3038
• 　  [hermes] Finalize removal of shadow crate code #3037
• 👉 [hermes] Remove diagnostic path mapping from shadow copy #3036
• 　  [hermes] Stop copying shadow crate; run in-place #3035
• 　  [hermes] Disable unsafe redaction #3034
• 　  [hermes] Take responsibility for all terminal UI #3019
• 　  [hermes] Get tests passing again #3018
• 　  [hermes] Add some tests for Charon invocation #3015
• 　  [hermes] Add Charon step #3014
• 　  [hermes] Isolate shadow crate from other artifacts #3013
• 　  [hermes] Add some trace/debug logging #3012
• 　  [hermes] Add one more UI test #3011
• 　  [hermes] Add fixture testing #3010
• 　  [hermes] Finish shadow crate creation #3009
• 　  [hermes] Discover mod foo; declarations #3008
• 　  [hermes] Resolve Cargo and Hermes target dirs #3007
• 　  [hermes] Add shadow copy creation #3006
• 　  [hermes] Add package/target/root resolution #3005
• 　  [hermes] Add source code transformation #3004
• 　  [hermes] Add UI testing #3003
• 　  [hermes] Initial commit of parser #3002

Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v1	Base
v2	vs v1	vs Base
v1		vs Base

⬇️ Download this PR

Branch

git fetch origin refs/heads/Gl2u5imkbil27nran4i72sxo5dzpixijo && git checkout -b pr-Gl2u5imkbil27nran4i72sxo5dzpixijo FETCH_HEAD

Checkout

git fetch origin refs/heads/Gl2u5imkbil27nran4i72sxo5dzpixijo && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gl2u5imkbil27nran4i72sxo5dzpixijo && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gl2u5imkbil27nran4i72sxo5dzpixijo

Stacked PRs enabled by GHerrit.

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the diagnostic path mapping mechanism within the Hermes tool by eliminating the concept of a "shadow copy" root. Previously, the DiagnosticMapper handled translating paths from a temporary shadow directory to the user's original source directory. This change removes that layer of indirection, simplifying the DiagnosticMapper's structure and its path resolution logic, which should lead to a more direct and efficient handling of diagnostic messages.

Highlights

• DiagnosticMapper Simplification: The DiagnosticMapper struct was refactored to remove the shadow_root field, simplifying its internal state.
• Constructor Update: The DiagnosticMapper::new constructor was updated to accept only the user_root path, removing the shadow_root argument.
• Path Mapping Logic Streamlined: The map_path method in DiagnosticMapper no longer attempts to strip prefixes based on a shadow_root, streamlining the path resolution process.
• charon.rs Integration: The run_charon function in charon.rs was updated to use the simplified DiagnosticMapper::new constructor.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tools/hermes/src/charon.rs
  • Updated the instantiation of DiagnosticMapper to align with its new constructor signature.
• tools/hermes/src/diagnostics.rs
  • Removed the shadow_root field from the DiagnosticMapper struct.
  • Modified the DiagnosticMapper::new function to no longer accept a shadow_root argument.
  • Eliminated the path mapping strategy that relied on the shadow_root prefix.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (c4c6eaa) to head (6a51e27).

Additional details and impacted files

@@                        Coverage Diff                         @@
##           G5bgufougyvpozncgq4yokgx3sie6wfy7    #3036   +/-   ##
==================================================================
  Coverage                              91.87%   91.87%           
==================================================================
  Files                                     20       20           
  Lines                                   6057     6057           
==================================================================
  Hits                                    5565     5565           
  Misses                                   492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request refactors the DiagnosticMapper to remove the concept of a shadow_root. This simplifies the implementation by removing redundant path mapping logic from a shadow copy to the user's workspace. The changes are consistent across charon.rs and diagnostics.rs, updating the DiagnosticMapper's constructor and removing the unused field and associated logic. The changes improve code clarity and maintainability. I have one piece of feedback regarding an outdated comment that results from these changes.

I am having trouble creating individual review comments. Click here to see my feedback.

tools/hermes/src/diagnostics.rs (68-71)

While removing this Strategy A block is correct, it leaves behind stale comments in the code that follows. Strategy B and Strategy C should be renamed to Strategy A and Strategy B respectively to maintain clarity and prevent confusion for future readers.

References

1. The repository style guide requires following guidelines in agent_docs/reviewing.md. The 'Style Cop' persona in that document emphasizes readability and project standards. Outdated comments harm readability and maintainability. ^(link)