[hermes] More aggressively test hidden item rejection#3047
[hermes] More aggressively test hidden item rejection#3047joshlf wants to merge 1 commit intoG3j7gcwkk2kr2uix4cyeyxid6egsuoa4efrom
Conversation
gherrit-pr-id: Gmkf32xtwlqyoky63oeo4l5id2hqup3os
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request strengthens the testing of Hermes's ability to correctly identify and reject hidden module declarations. By introducing an additional layer of nesting for a hidden module within a function, the changes ensure that the system's logic for ignoring such items is robust under more complex scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request strengthens the test suite for hermes by making the test for rejecting items in hidden modules more aggressive. The change introduces an additional level of module nesting within a function body, ensuring that hermes correctly identifies and rejects annotated items regardless of nesting depth. The code change is clear, and the updated comment accurately reflects the new test's intent. This is a good improvement for the robustness of the tool.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3j7gcwkk2kr2uix4cyeyxid6egsuoa4e #3047 +/- ##
==================================================================
Coverage 91.87% 91.87%
==================================================================
Files 20 20
Lines 6057 6057
==================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR is on branch hermes.
#[cfg_attr(..., path = "...")]#3045unsaferedaction #3034mod foo;declarations #3008Latest Update: v11 — Compare vs v10
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gmkf32xtwlqyoky63oeo4l5id2hqup3os && git checkout -b pr-Gmkf32xtwlqyoky63oeo4l5id2hqup3os FETCH_HEADCheckout
git fetch origin refs/heads/Gmkf32xtwlqyoky63oeo4l5id2hqup3os && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gmkf32xtwlqyoky63oeo4l5id2hqup3os && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.