[hermes] Warn on #[cfg_attr(..., path = "...")]
#3045
Conversation
gherrit-pr-id: Gegf4fywvkwtqzwzektqc5lett4skoxvx
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Hermes's parsing capabilities by introducing a warning for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a warning for #[cfg_attr(..., path = "...")] attributes on modules, as Hermes does not support conditional path evaluation. This is a useful addition to inform users about potential issues. The implementation involves a new function to extract the path from the attribute and modifications to the AST visitor. The integration test suite is also enhanced to allow setting log levels, which is used to verify the new warning.
The changes are well-implemented. I have one suggestion to improve the new extract_cfg_attr_path function by simplifying some nested logic and adding error handling for a currently ignored Result, which will improve robustness and debuggability.
| let _ = attr.parse_nested_meta(|meta| { | ||
| if meta.path.is_ident("path") { | ||
| if let Ok(value) = meta.value() { | ||
| if let Ok(lit) = value.parse::<Lit>() { | ||
| if let Lit::Str(lit_str) = lit { | ||
| found_path = Some(lit_str.value()); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Ok(()) | ||
| }); |
There was a problem hiding this comment.
The result of attr.parse_nested_meta is ignored. It's better to handle the Result, for example by logging errors, to aid in debugging. Additionally, the nested if statements for parsing the literal can be simplified by combining them.
| let _ = attr.parse_nested_meta(|meta| { | |
| if meta.path.is_ident("path") { | |
| if let Ok(value) = meta.value() { | |
| if let Ok(lit) = value.parse::<Lit>() { | |
| if let Lit::Str(lit_str) = lit { | |
| found_path = Some(lit_str.value()); | |
| } | |
| } | |
| } | |
| } | |
| Ok(()) | |
| }); | |
| if let Err(e) = attr.parse_nested_meta(|meta| { | |
| if meta.path.is_ident("path") { | |
| if let Ok(value) = meta.value() { | |
| if let Ok(Lit::Str(lit_str)) = value.parse() { | |
| found_path = Some(lit_str.value()); | |
| } | |
| } | |
| } | |
| Ok(()) | |
| }) { | |
| trace!("Failed to parse nested meta in `cfg_attr`: {}", e); | |
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gulbf5jp7zpz4nn77nspxpsiy3tadde54 #3045 +/- ##
==================================================================
Coverage 91.87% 91.87%
==================================================================
Files 20 20
Lines 6057 6057
==================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR is on branch hermes.
#[cfg_attr(..., path = "...")]#3045unsaferedaction #3034mod foo;declarations #3008Latest Update: v9 — Compare vs v8
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gegf4fywvkwtqzwzektqc5lett4skoxvx && git checkout -b pr-Gegf4fywvkwtqzwzektqc5lett4skoxvx FETCH_HEADCheckout
git fetch origin refs/heads/Gegf4fywvkwtqzwzektqc5lett4skoxvx && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gegf4fywvkwtqzwzektqc5lett4skoxvx && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.