[hermes] Stop copying shadow crate; run in-place #3035
Conversation
gherrit-pr-id: G5bgufougyvpozncgq4yokgx3sie6wfy7
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Hermes analysis workflow by eliminating the intermediate 'shadow crate' step. Instead of copying project files to a temporary location for analysis, Hermes will now operate directly on the existing project structure. This change reduces file I/O, simplifies the internal architecture, and removes a layer of abstraction that is no longer necessary, leading to a more efficient and straightforward process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G4otukodorqa35fh3ms527yqmldc7g7ft #3035 +/- ##
====================================================================
Coverage ? 91.87%
====================================================================
Files ? 20
Lines ? 6057
Branches ? 0
====================================================================
Hits ? 5565
Misses ? 492
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the concept of a shadow crate, simplifying the verification process by running charon directly on the source workspace. The changes are consistent and well-executed. I have a couple of suggestions to improve code clarity by renaming a function and a variable that are now misleading after this refactoring.
| // inserted one for each package that has a root. | ||
| let shadow_manifest_path = | ||
| shadow_manifest_paths.get(&target.name.package_name).unwrap(); | ||
| let manifest_path = find_package_root(&target.src_path).ok()?.join("Cargo.toml"); |
There was a problem hiding this comment.
Since this function no longer builds a shadow crate, its name build_shadow_crate has become misleading. For better clarity and maintainability, consider renaming it to something like find_hermes_artifacts. This would also require updating its documentation and any call sites.
| // We still need the path for mapping `[SHADOW_ROOT]` correctly! | ||
| // But we construct it manually since it might not be created yet: | ||
| let abs_shadow_root = std::env::current_dir().unwrap().join(&shadow_root); | ||
| let abs_shadow_root = std::env::current_dir().unwrap().join(&sandbox_root); |
There was a problem hiding this comment.
The variable abs_shadow_root is now misleading since shadow crates are no longer used. It actually holds the absolute path to the sandbox root. Renaming it to abs_sandbox_root would make the code easier to understand. You'll need to update its usage below as well.
| let abs_shadow_root = std::env::current_dir().unwrap().join(&sandbox_root); | |
| let abs_sandbox_root = std::env::current_dir().unwrap().join(&sandbox_root); |
2 participants
This PR is on branch hermes.
#[cfg_attr(..., path = "...")]#3045unsaferedaction #3034mod foo;declarations #3008Latest Update: v10 — Compare vs v9
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G5bgufougyvpozncgq4yokgx3sie6wfy7 && git checkout -b pr-G5bgufougyvpozncgq4yokgx3sie6wfy7 FETCH_HEADCheckout
git fetch origin refs/heads/G5bgufougyvpozncgq4yokgx3sie6wfy7 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G5bgufougyvpozncgq4yokgx3sie6wfy7 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.