feat(ui): adds created and updated date display to issue and PR rows#39
Merged
wgordon17 merged 19 commits intogordon-code:mainfrom Mar 31, 2026
Merged
feat(ui): adds created and updated date display to issue and PR rows#39wgordon17 merged 19 commits intogordon-code:mainfrom
wgordon17 merged 19 commits intogordon-code:mainfrom
Conversation
- splits timeInfo into staticDateInfo and dateDisplay memos (perf, clarity) - adds future-timestamp guard to relativeTime (clock skew consistency) - aligns Date.parse usage across relativeTime and shortRelativeTime - documents void props.refreshTick reactive dependency pattern - migrates WorkflowRunRow to semantic <time> element with createMemo - wires refreshTick through ActionsTab to WorkflowRunRow - adds boundary tests (59s/60s, 29d/30d, 11mo/12mo) - adds datetime attribute, zero-diff, and future relativeTime tests
- adds 60s wall-clock tick for relative time freshness (cor-1) - memoizes WorkflowRunRow tooltip with Created prefix (cq-1, cq-2) - renames hasUpdate to shouldShowUpdated (cq-5) - simplifies duplicate reactivity comments (cq-4) - switches ItemRow test locators to querySelector (gordon-codegh-5) - fixes double-mock pattern with vi.mocked (qa-4) - adds 2mo, invalid date, and title attribute tests (qa-1, qa-2, qa-3)
- adds external-link icon on repo group headers linking to GitHub per tab - moves scrollbar to viewport edge via page scroll with sticky tabs - adds depDashboard filter with toggle pill, hidden by default - fixes detectReorderedRepos false flash on repo add/remove - extracts ExternalLinkIcon shared component - preserves depDashboard toggle across resetAllTabFilters - uses schema defaults in resetTabFilter instead of hardcoded all
- Extracts RepoGitHubLink shared component, replacing duplicated anchor markup in IssuesTab, PullRequestsTab, and ActionsTab - Moves clockInterval inside onMount to match coordinator lifecycle pattern - Promotes depDashboard from string enum in tabFilters to top-level boolean (hideDepDashboard), eliminating resetAllTabFilters preserve hack - Expands void refreshTick comments to explain SolidJS dependency tracking mechanism - Normalizes Date.parse() usage in formatDuration for consistency with relativeTime/shortRelativeTime - Adds tests for mixed valid/invalid dates, 360-day boundary, external link rendering, clock cleanup specificity, and hideDepDashboard lifecycle
wgordon17
force-pushed
the
worktree-date-display
branch
from
fc99098 to
ff9d4cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shortRelativeTime()compact formatter (now,5m,3h,7d,2mo,1y) and dual inline date display on ItemRow showing both created and updated timesrefreshTickfrom DashboardPage through tabs for reactive time display with 60s threshold and display-equality guard to suppress redundant updates<time>elements withdatetimeattributes,aria-labelfor screen readers, and human-readable tooltips viatoLocaleString()