Cleanup create and save override API#424
Merged
Merged
Conversation
Remove all business logic from gsad and just forward the parameters to gvmd. This change just converts the sent parameters to GMP XML and checks the required ones before.
These functions were used to implement some business logic within gsad to decide which parameter contains the to be used values for being included in the GMP XML request. This got simplified and now the functions are not used anymore.
ozgen
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleanup create and save override API
Why
Remove all business logic from gsad and just forward the parameters to gvmd. This change just converts the sent parameters to GMP XML and checks the required ones before.
References
https://jira.greenbone.net/browse/GEA-1870