ci: use hosted runners for public workflows - #102
Conversation
Version Bump PreviewWhen this PR is merged, @happyvertical/spider will receive a patch version bump based on your conventional commits. What happens on merge?
No manual intervention needed! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea0d853b1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| test: | ||
| name: Run Tests | ||
| runs-on: arc-happyvertical | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
When a PR, main push, or the publish workflow invokes this test job on GitHub-hosted ubuntu-latest, the job still sets PLAYWRIGHT_BROWSERS_PATH=/ms-playwright and disables browser downloads, then runs pnpm browser:runtime:check. That script explicitly requires Chromium, headless-shell, and ffmpeg revision directories under /ms-playwright; those were supplied by the former ARC image but are not provisioned anywhere in this workflow, so the runtime check fails before build and tests, also blocking releases. Update the hosted-runner path to install the required Playwright runtime (and dependencies) rather than retaining the baked-image contract.
Useful? React with 👍 / 👎.
willgriffin
added
the
skip-changeset
4d787c2 to
91d0067
Compare
|
@codex review exact head Please review this runner-routing change for the trust boundary (private general vs cluster-bound vs public untrusted), workflow correctness, required-check preservation, and any provider-specific leakage. Report actionable findings or explicitly clean. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91d0067ee7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Install Playwright runtime | ||
| run: pnpm exec playwright install --with-deps chromium |
There was a problem hiding this comment.
The hosted workflow now downloads Playwright into the workspace, but README.md lines 248–254 still states that CI uses /ms-playwright, disables downloads, validates a baked ARC image, and links to the provider-specific happyvertical/iac#1000 issue. This leaves the public deployment guidance describing a runtime guarantee that CI no longer provides and retains the provider-specific leakage this routing change is intended to remove; update that section alongside the workflow.
Useful? React with 👍 / 👎.
1 participant
Summary
ubuntu-latestValidation
No runner backend activation or production cutover was performed.
Resolves #101
Epic: happyvertical/iac#1088
{"runtime":"codex","session":"codex-101-runner-pool-019f9ea2","policy_revision":"1.0.0","validation":"pre-push typecheck; actionlint; public v3 target audit; diff check","schema":"hv-agent-run:v1","issue":101}