Skip to content

ci: use hosted runners for public workflows #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willgriffin merged 2 commits into from
Jul 29, 2026
Merged

ci: use hosted runners for public workflows #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0d853
ci: use hosted runners for public workflows
willgriffin Jul 26, 2026
91d0067
fix(spider): install Playwright on hosted runners
willgriffin Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changeset-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
jobs:
check:
name: Check for Changeset
runs-on: arc-happyvertical
runs-on: ubuntu-latest

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
jobs:
validate-commits:
name: Validate Conventional Commits
runs-on: arc-happyvertical
runs-on: ubuntu-latest

steps:
- name: Checkout PR branch
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
release:
name: Version and Publish
needs: test
runs-on: arc-happyvertical
runs-on: ubuntu-latest
timeout-minutes: 20

steps:
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,11 @@ permissions:
jobs:
test:
name: Run Tests
runs-on: arc-happyvertical
runs-on: ubuntu-latest

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install Playwright before using hosted test runners

When a PR, main push, or the publish workflow invokes this test job on GitHub-hosted ubuntu-latest, the job still sets PLAYWRIGHT_BROWSERS_PATH=/ms-playwright and disables browser downloads, then runs pnpm browser:runtime:check. That script explicitly requires Chromium, headless-shell, and ffmpeg revision directories under /ms-playwright; those were supplied by the former ARC image but are not provisioned anywhere in this workflow, so the runtime check fails before build and tests, also blocking releases. Update the hosted-runner path to install the required Playwright runtime (and dependencies) rather than retaining the baked-image contract.

Useful? React with 👍 / 👎.

env:
EXPECTED_PLAYWRIGHT_CHROMIUM_REVISION: '1228'
EXPECTED_PLAYWRIGHT_VERSION: '1.61.1'
PLAYWRIGHT_BROWSERS_PATH: /ms-playwright
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/.cache/ms-playwright
# Backstop so a stalled step (e.g. a hung browser download) fails fast
# instead of sitting until the 6h default.
timeout-minutes: 30
Expand Down Expand Up @@ -51,10 +50,13 @@ jobs:
- name: Install dependencies
run: pnpm install

# The ARC image must already contain the exact browser revision required
# by package.json. Downloads stay disabled so image/package drift fails
# immediately instead of mutating the runner. See happyvertical/iac#1000.
- name: Verify baked Playwright runtime
# Public pull requests run on GitHub-hosted capacity and cannot depend on
# the private ARC image. Playwright resolves the exact browser revision
# pinned by the lockfile before the existing runtime check verifies it.
- name: Install Playwright runtime
run: pnpm exec playwright install --with-deps chromium
Comment on lines +56 to +57

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the documented CI runtime contract

The hosted workflow now downloads Playwright into the workspace, but README.md lines 248–254 still states that CI uses /ms-playwright, disables downloads, validates a baked ARC image, and links to the provider-specific happyvertical/iac#1000 issue. This leaves the public deployment guidance describing a runtime guarantee that CI no longer provides and retains the provider-specific leakage this routing change is intended to remove; update that section alongside the workflow.

Useful? React with 👍 / 👎.


- name: Verify Playwright runtime
run: pnpm browser:runtime:check

- name: Build
Expand Down
Loading