Skip to content

BE-398: Remove hardcoded database names from environment files#8418

Merged
TimDiekmann merged 1 commit intomainfrom
t/be-398-remove-envdevelopment-custom-db-identifier
Feb 13, 2026
Merged

BE-398: Remove hardcoded database names from environment files#8418
TimDiekmann merged 1 commit intomainfrom
t/be-398-remove-envdevelopment-custom-db-identifier

Conversation

@TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

Remove hardcoded database name environment variables from configuration files

🔍 What does this change?

  • Removes database name environment variables from .env.development and .env.test
  • Removes database name overrides from GitHub workflow files

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

  • Existing CI workflows will validate the changes

❓ How to test this?

  1. Checkout the branch
  2. Run the application in development mode
  3. Confirm that database connections work correctly without the hardcoded database names

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Feb 13, 2026 4:19pm
hashdotdesign Ready Ready Preview, Comment Feb 13, 2026 4:19pm
hashdotdesign-tokens Ready Ready Preview, Comment Feb 13, 2026 4:19pm
petrinaut Ready Ready Preview Feb 13, 2026 4:19pm

@cursor
Copy link

cursor bot commented Feb 13, 2026

PR Summary

Low Risk
Config-only changes that remove overrides; risk is limited to dev/CI breaking if any environment still implicitly relied on the old database names.

Overview
Removes hardcoded Postgres database name env vars from .env.development and .env.test, relying on defaults/overrides instead.

Updates CI workflows (test.yml, bench.yml) to stop injecting HASH_GRAPH_PG_DATABASE into .env.local/job env when bringing up external services.

Written by Cursor Bugbot for commit 7b5761c. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Feb 13, 2026
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@augmentcode
Copy link

augmentcode bot commented Feb 13, 2026

🤖 Augment PR Summary

Summary: Removes environment-specific Postgres database name overrides from development/test env files and CI workflows.

Changes:

  • Deleted hardcoded `*_PG_DATABASE` values from .env.development and .env.test so defaults come from the base .env / app defaults.
  • Removed HASH_GRAPH_PG_DATABASE overrides in GitHub Actions bench/test workflows when launching external services.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

HASH_KRATOS_PG_DATABASE=test_kratos
HASH_TEMPORAL_PG_DATABASE=test_temporal
HASH_TEMPORAL_VISIBILITY_PG_DATABASE=test_temporal_visibility
HASH_GRAPH_PG_DATABASE=test_graph
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the test_* DB name overrides means external-services:test will now use the same Postgres database names as development (via .env defaults), which may no longer match the README claim that test mode avoids polluting the dev DB. If that isolation is still required, it’s worth double-checking there’s another separation mechanism (different DB names/ports/project/volume) after this change.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 21 untouched benchmarks
🗄️ 12 archived benchmarks run1


Comparing t/be-398-remove-envdevelopment-custom-db-identifier (7b5761c) with main (c8e4ac9)2

Open in CodSpeed

Footnotes

  1. 12 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

  2. No successful run was found on main (c5edd55) during the generation of this report, so c8e4ac9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indietyp approved this PR from Slack with Graphite

Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indietyp approved this PR from Slack with Graphite

@TimDiekmann TimDiekmann added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 7b26816 Feb 13, 2026
175 of 177 checks passed
@TimDiekmann TimDiekmann deleted the t/be-398-remove-envdevelopment-custom-db-identifier branch February 13, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area)

Development

Successfully merging this pull request may close these issues.

2 participants