BE-398: Remove hardcoded database names from environment files#8418
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Updates CI workflows ( Written by Cursor Bugbot for commit 7b5761c. This will update automatically on new commits. Configure here. |
🤖 Augment PR SummarySummary: Removes environment-specific Postgres database name overrides from development/test env files and CI workflows. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| HASH_KRATOS_PG_DATABASE=test_kratos | ||
| HASH_TEMPORAL_PG_DATABASE=test_temporal | ||
| HASH_TEMPORAL_VISIBILITY_PG_DATABASE=test_temporal_visibility | ||
| HASH_GRAPH_PG_DATABASE=test_graph |
There was a problem hiding this comment.
Removing the test_* DB name overrides means external-services:test will now use the same Postgres database names as development (via .env defaults), which may no longer match the README claim that test mode avoids polluting the dev DB. If that isolation is still required, it’s worth double-checking there’s another separation mechanism (different DB names/ports/project/volume) after this change.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Merging this PR will not alter performance
Comparing Footnotes
|

🌟 What is the purpose of this PR?
Remove hardcoded database name environment variables from configuration files
🔍 What does this change?
.env.developmentand.env.testPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?