Skip to content

BE-398: Remove hardcoded database names from environment files #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimDiekmann merged 1 commit into from
Feb 13, 2026
+0 −20
Merged

BE-398: Remove hardcoded database names from environment files #8418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
# The values contained within this dotfile are provided to development instances of HASH
# These variables can be locally overridden by re-specifying them in a `.env.development.local` file

HASH_KRATOS_PG_DATABASE=dev_kratos
HASH_TEMPORAL_PG_DATABASE=dev_temporal
HASH_TEMPORAL_VISIBILITY_PG_DATABASE=dev_temporal_visibility
HASH_GRAPH_PG_DATABASE=dev_graph

HASH_GRAPH_RPC_ENABLED=true
HASH_RPC_ENABLED=true

Expand Down
4 changes: 0 additions & 4 deletions .env.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
# The values contained within this dotfile are provided to test instances of HASH
# These variables can be locally overridden by re-specifying them in a `.env.test.local` file

HASH_KRATOS_PG_DATABASE=test_kratos
HASH_TEMPORAL_PG_DATABASE=test_temporal
HASH_TEMPORAL_VISIBILITY_PG_DATABASE=test_temporal_visibility
HASH_GRAPH_PG_DATABASE=test_graph
Copy link

@augmentcode augmentcode bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the test_* DB name overrides means external-services:test will now use the same Postgres database names as development (via .env defaults), which may no longer match the README claim that test mode avoids polluting the dev DB. If that isolation is still required, it’s worth double-checking there’s another separation mechanism (different DB names/ports/project/volume) after this change.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

HASH_GRAPH_ALLOWED_URL_DOMAIN_PATTERN="(?:http://localhost:3000|https://hash\\.ai)/@(?P<shortname>[\\w-]+)/types/(?P<kind>(?:data-type)|(?:property-type)|(?:entity-type))/[\\w\\-_%]+/"

# For locally-running minio instance
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ jobs:
strategy:
matrix: ${{ fromJSON(needs.setup.outputs.integration) }}
fail-fast: false
env:
HASH_GRAPH_PG_DATABASE: graph
if: needs.setup.outputs.integration != '{"name":[],"include":[]}'
runs-on: ubuntu-24.04
steps:
Expand Down Expand Up @@ -236,9 +234,6 @@ jobs:
if: github.event_name == 'pull_request'
run: |
touch .env.local

echo 'HASH_GRAPH_PG_DATABASE=graph' > .env.local

cp .env.local .env.test.local
yarn external-services:test up --wait

Expand Down Expand Up @@ -316,9 +311,6 @@ jobs:
- name: Launch external services
run: |
touch .env.local

echo 'HASH_GRAPH_PG_DATABASE=graph' > .env.local

cp .env.local .env.test.local
yarn external-services:test up --wait

Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,6 @@ jobs:
echo 'ANTHROPIC_API_KEY=dummy' >> .env.local
echo 'HASH_TEMPORAL_WORKER_AI_AWS_ACCESS_KEY_ID=dummy' >> .env.local
echo 'HASH_TEMPORAL_WORKER_AI_AWS_SECRET_ACCESS_KEY=dummy' >> .env.local

echo 'HASH_GRAPH_PG_DATABASE=graph' >> .env.local

cp .env.local .env.test.local
yarn external-services:test up --wait

Expand Down
Loading