version 1.1.0

[hessius]

No description provided.

[hessius]

@copilot python tests failing

The failing tests are caused by errors like:

Failed to schedule shot: schedule_shot.<locals>.execute_scheduled_shot() got an unexpected keyword argument 'schedule_id'

This indicates that in your /api/machine/schedule-shot endpoint, you are trying to call execute_scheduled_shot with a keyword argument schedule_id, but the async function on line 2057 does not accept schedule_id as a keyword argument.

Solution

Update the code in your async task creation (lines ~6169–6177):

task = asyncio.create_task(
    execute_scheduled_shot(
        schedule_id=schedule_id,
        shot_delay=shot_delay,
        preheat=preheat,
        profile_id=profile_id,
        scheduled_shots_dict=_scheduled_shots,
        scheduled_tasks_dict=_scheduled_tasks,
        preheat_duration_minutes=PREHEAT_DURATION_MINUTES
    )
)

to a positional invocation:

task = asyncio.create_task(
    execute_scheduled_shot(
        schedule_id,
        shot_delay,
        preheat,
        profile_id,
        _scheduled_shots,
        _scheduled_tasks,
        PREHEAT_DURATION_MINUTES
    )
)

Why this works:
Your execute_scheduled_shot definition takes only positional parameters, not keyword arguments. Python throws a TypeError when you pass keyword arguments not explicitly allowed.

Code Fix Example

Replace lines 6169–6177 in main.py:

task = asyncio.create_task(
    execute_scheduled_shot(
        schedule_id,
        shot_delay,
        preheat,
        profile_id,
        _scheduled_shots,
        _scheduled_tasks,
        PREHEAT_DURATION_MINUTES
    )
)

This should resolve the test failures related to scheduling shots and cancellation.

Summary:
Pass all arguments to execute_scheduled_shot positionally instead of by keyword throughout your scheduling endpoints. This fixes the unexpected keyword argument error and will allow your scheduled shot endpoints to function as intended.

[Copilot]

@hessius I've opened a new pull request, #128, to work on those changes. Once the pull request is ready, I'll request review from you.

[hessius]

@copilot test coverage has now fallen below threshold. Please aim for coverage of 75%, even if current threshold is just 68%. If 75% is reached please adjust the threshold upwards. DO NOT adjust the threshold downward.

[Copilot]

@hessius I've opened a new pull request, #129, to work on those changes. Once the pull request is ready, I'll request review from you.

[hessius]

Version 1.1.0 - Ready for Review

New Features

• Profile Target Curves: Generate target overlay curves for shot analysis charts

  • Supports both nested (dynamics.points) and flat (dynamics_points) formats
  • Proper handling of embedded profiles in shot data

• Extraction Summary: Backend now calculates extraction stage summaries

Fixes

• Flow Stage Assessment: Now uses end_flow instead of max_flow for flow stage assessments
  • The initial peak flow from piston retraction was misleading users
  • Assessment now correctly reflects stabilized flow values

Tests

• Added 4 new tests:
  • test_generate_profile_target_curves_nested_dynamics_format
  • test_generate_profile_target_curves_handles_both_formats
  • test_flow_stage_assessment_uses_end_flow_not_max_flow
  • test_pressure_stage_assessment_uses_max_pressure

All unit tests passing (31 tests).