Fix schedule_shot async task invocation with incorrect parameters #128
+1
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
execute_scheduled_shot()nested async function was being invoked with keyword arguments it doesn't accept, causing all scheduled shot tests to fail withTypeError: got an unexpected keyword argument 'schedule_id'.Changes
asyncio.create_task()callschedule_id,shot_delay,preheat, etc. argumentscreate_task(execute_scheduled_shot(schedule_id=..., shot_delay=..., ...))tocreate_task(execute_scheduled_shot())Example
This fixes 6 failing test cases in
TestRunShotEndpointsandTestScheduledShotsPersistence.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.