Open
Conversation
The previous regular expression caused problems with input filenames containing the substring "pp" because the "." characters in the pattern were not escaped. Also enforce the appearance of ".pp." just before the fastq or fq extensions.
Contributor
|
Dear eernst, thanks a lot for pointing out this problem. However, your bugfix still caused problems, e.g. in the cat command which would have created a single file containing the raw and preprocessed reads for indexing. We have fixed the problem now by adding the string SGAICE to all temporary files. And the script error-exits in case the user inputs files that have this string. Let us know if there are any other issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regular expression caused problems with input filenames containing the substring "pp" because the "." characters in the pattern were not escaped. Also enforce the appearance of ".pp." just before the fastq or fq extensions.