fix: make bond early_unlock_admin nullable#2580
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
setup-bondpox-5 event no longer carries anearly_unlock_adminfield, but thebondstable still defined theearly_unlock_admincolumn asNOT NULL, forcing ingestion to write an empty-string placeholder. This makes the column nullable so bond creation can simply skip it.setup-bondevent and stop persisting a meaningless placeholder value.bondsmigration:early_unlock_adminis now nullable (droppedNOT NULL).updateBond): no longer setsearly_unlock_admin(removed the''placeholder + itsTODO); the column defaults toNULL.DbBondInsertValues: dropped theearly_unlock_adminfield (no longer written).DbBond:early_unlock_adminread type is nowstring | null.early_unlock_adminis not exposed in any response/serializer; it remains an internal column (now nullable).setup-bondevent change (feat: capture bond registration BTC/sBTC lockup data #2579).Type of Change
Does this introduce a breaking change?
No. Targets the unreleased
pox5line; the column is internal and not serialized in any API response.Are documentation updates required?
Testing information
tests/api/pox5/bonds.test.tssuite — theSETUP_BOND_DATAfixture no longer includesearly_unlock_admin, matching the new event shape.setup-bondingestion (pg-write-store→updateBond),bondsmigration, and the bond DB types.early_unlock_adminon the read path;BOND_COLUMNSstill selects it (now returnsnull). Verified withnpm run test:api:pox5(bonds suite: 17/17 passing).🤖 Generated with Claude Code