Skip to content

fix: make bond early_unlock_admin nullable #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafa-stacks merged 1 commit into from
Jun 11, 2026
+1 −5
Merged

fix: make bond early_unlock_admin nullable #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion migrations/1779487960678_bonds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export const up = (pgm: MigrationBuilder) => {
},
early_unlock_admin: {
type: 'text',
notNull: true,
},
first_reward_cycle: {
type: 'integer',
Expand Down
1 change: 0 additions & 1 deletion src/datastore/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@
canonical: boolean;

microblock_canonical: boolean;
// TODO(mb): should probably be (number | null) rather than -1 for batched tx

Check warning on line 212 in src/datastore/common.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected 'todo' comment: 'TODO(mb): should probably be (number |...'
microblock_sequence: number;
// TODO(mb): should probably be (string | null) rather than empty string for batched tx

Check warning on line 214 in src/datastore/common.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected 'todo' comment: 'TODO(mb): should probably be (string |...'
microblock_hash: string;

post_conditions: string;
Expand Down Expand Up @@ -1655,7 +1655,6 @@
unlock_cycle: number;
unlock_burn_height: number;
early_unlock_bytes: string;
early_unlock_admin: string;
}

/** How the BTC backing a bond registration was locked. */
Expand Down
1 change: 0 additions & 1 deletion src/datastore/pg-write-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@
break;
case Pox5EventName.ClaimRewards:
case Pox5EventName.ClaimStakerRewardsForSigner:
// TODO: Implement

Check warning on line 585 in src/datastore/pg-write-store.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected 'todo' comment: 'TODO: Implement'
break;
case Pox5EventName.Stake:
case Pox5EventName.StakeUpdate:
Expand Down Expand Up @@ -617,7 +617,6 @@
stx_value_ratio: parseInt(event.data.stx_value_ratio),
min_ustx_ratio: parseInt(event.data.min_ustx_ratio),
early_unlock_bytes: event.data.early_unlock_bytes,
early_unlock_admin: '', // TODO: Make nullable
first_reward_cycle: parseInt(event.data.first_reward_cycle),
bond_start_height: parseInt(event.data.bond_start_height),
unlock_cycle: parseInt(event.data.unlock_cycle),
Expand Down
2 changes: 1 addition & 1 deletion src/datastore/v3/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export interface DbBondSummary {

export interface DbBond extends DbBondSummary, DbTxLocation {
early_unlock_bytes: string;
early_unlock_admin: string;
early_unlock_admin: string | null;
}

export interface DbBondAllowlistEntry {
Expand Down
1 change: 0 additions & 1 deletion tests/api/pox5/bonds.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const SETUP_BOND_DATA = {
stx_value_ratio: String(STX_VALUE_RATIO),
min_ustx_ratio: String(MIN_USTX_RATIO),
early_unlock_bytes: '',
early_unlock_admin: ADMIN,
first_reward_cycle: String(FIRST_REWARD_CYCLE),
bond_start_height: String(BOND_START_HEIGHT),
unlock_cycle: String(UNLOCK_CYCLE),
Expand Down
Loading