Skip to content

feat: set working directory#77

Open
umar-muneer wants to merge 9 commits intohjylewis:masterfrom
umar-muneer:working-dir
Open

feat: set working directory#77
umar-muneer wants to merge 9 commits intohjylewis:masterfrom
umar-muneer:working-dir

Conversation

@umar-muneer
Copy link

@umar-muneer umar-muneer commented Feb 3, 2020

  • Read Config from a provided working directory
  • Write Record to a provided working directory
  • A new option has been added to the cli --working-dir
  • files are provided to the cli the same way as before.

Todo:

  • update readme

@umar-muneer umar-muneer requested a review from hjylewis as a code owner February 3, 2020 16:46
@umar-muneer umar-muneer changed the title Working dir Set Working dir for Config and Record file Feb 3, 2020
@umar-muneer umar-muneer changed the title Set Working dir for Config and Record file feat: set working directory Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.2%.
The diff coverage is 99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   98.31%   98.11%   -0.21%     
==========================================
  Files          11       12       +1     
  Lines         357      372      +15     
  Branches       47       51       +4     
==========================================
+ Hits          351      365      +14     
- Misses          6        7       +1
Impacted Files Coverage Δ
lib/config.js 100% <100%> (ø) ⬆️
__tests__/config/fixtures/.esplintrc.js 100% <100%> (ø)
lib/cli.js 94.02% <100%> (ø) ⬆️
lib/record.js 100% <100%> (ø) ⬆️
lib/engine.js 98.8% <98.8%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04bb9d1...42bab75. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant