-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 3 vulnerabilities #11556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading key Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis PR updates the dependency management strategy for the LDAP catalog backend module by replacing workspace protocol references with explicit version numbers. Four Backstage packages are affected: backend-tasks (0.6.1), catalog-model (0.1.1), plugin-catalog-common (0.1.0), and plugin-catalog-node (1.0.0). This transition from Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Build as Build System
participant LDAP as catalog-backend-module-ldap
participant BT as @backstage/backend-tasks v0.6.1
participant CM as @backstage/catalog-model v0.1.1
participant CC as @backstage/plugin-catalog-common v0.1.0
participant CN as @backstage/plugin-catalog-node v1.0.0
Note over Build,CN: Dependency Resolution During Build
Build->>LDAP: Install dependencies
activate LDAP
LDAP->>BT: Resolve backend-tasks (now pinned to 0.6.1)
BT-->>LDAP: Package installed
LDAP->>CM: Resolve catalog-model (now pinned to 0.1.1)
CM-->>LDAP: Package installed
LDAP->>CC: Resolve catalog-common (now pinned to 0.1.0)
CC-->>LDAP: Package installed
LDAP->>CN: Resolve catalog-node (now pinned to 1.0.0)
CN-->>LDAP: Package installed
deactivate LDAP
Note over Build,CN: Changed from workspace references to fixed versions
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix three vulnerabilities by changing dependency versions in plugins/catalog-backend-module-ldap/package.json. However, the proposed changes are incorrect and will likely break the project. The PR replaces workspace:^ dependencies with pinned, and in most cases, severely outdated versions from the public registry. This goes against the monorepo structure of this project. These changes should be rejected, and the vulnerabilities should be addressed manually by updating the appropriate dependencies and regenerating the yarn.lock file.
| "@backstage/backend-tasks": "0.6.1", | ||
| "@backstage/catalog-model": "0.1.1", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-catalog-common": "workspace:^", | ||
| "@backstage/plugin-catalog-node": "workspace:^", | ||
| "@backstage/plugin-catalog-common": "0.1.0", | ||
| "@backstage/plugin-catalog-node": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are incorrect and will likely break the build. Replacing workspace:^ with pinned versions from the public registry defeats the purpose of a monorepo using Yarn workspaces. It forces this package to use different (and in this case, much older) versions of @backstage packages than the rest of the monorepo.
For example:
@backstage/catalog-modelis being downgraded from version1.4.1in the workspace to0.1.1.@backstage/plugin-catalog-commonis being downgraded from1.0.15to0.1.0.@backstage/plugin-catalog-nodeis being downgraded from1.4.1-next.0to1.0.0.
This will lead to version mismatches and likely cause compilation or runtime errors. The correct approach is to identify the root dependency causing the vulnerability and update it across the monorepo, then run yarn to update the lockfile. This PR should be closed and the fix should be applied manually.
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^"
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/catalog-backend-module-ldap/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR transitions the LDAP catalog backend module from workspace-based dependency management to pinned external package versions.
workspace:^protocol with explicit version0.6.1for@backstage/backend-tasksworkspace:^protocol with explicit version0.1.1for@backstage/catalog-modelworkspace:^protocol with explicit version0.1.0for@backstage/plugin-catalog-commonworkspace:^protocol with explicit version1.0.0for@backstage/plugin-catalog-nodeplugins/catalog-backend-module-ldap/package.json