Skip to content

[Snyk] Fix for 3 vulnerabilities #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-ldap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +35 to +40
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes are incorrect and will likely break the build. Replacing workspace:^ with pinned versions from the public registry defeats the purpose of a monorepo using Yarn workspaces. It forces this package to use different (and in this case, much older) versions of @backstage packages than the rest of the monorepo.

For example:

  • @backstage/catalog-model is being downgraded from version 1.4.1 in the workspace to 0.1.1.
  • @backstage/plugin-catalog-common is being downgraded from 1.0.15 to 0.1.0.
  • @backstage/plugin-catalog-node is being downgraded from 1.4.1-next.0 to 1.0.0.

This will lead to version mismatches and likely cause compilation or runtime errors. The correct approach is to identify the root dependency causing the vulnerability and update it across the monorepo, then run yarn to update the lockfile. This PR should be closed and the fix should be applied manually.

    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

"@backstage/types": "workspace:^",
"@types/ldapjs": "^2.2.0",
"ldapjs": "^2.2.0",
Expand Down
Loading