fix(pi0): avoid 3x peak RAM in PiGemma construction#3326
Open
AjAnubolu wants to merge 2 commits intohuggingface:mainfrom
Open
fix(pi0): avoid 3x peak RAM in PiGemma construction#3326AjAnubolu wants to merge 2 commits intohuggingface:mainfrom
AjAnubolu wants to merge 2 commits intohuggingface:mainfrom
Conversation
…uggingface#3251) Signed-off-by: AjAnubolu <anuboluajay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PI0/PI05/PI0FAST construction allocates
GemmaModelthree times (parents build it, subclasses immediately discard and replace it), pushing peak RSS to ~3x the final model size and OOMing 32 GB machines. Wraps eachsuper().__init__()inaccelerate.init_empty_weights()so discarded submodules cost zero RAM, then rebuilds only the kept ones on real device.Closes #3251. Diagnostic traces in #3254.