Skip to content

Use built-in GITHUB_ACTIONS variable instead of custom IS_GITHUB_CI - #6749

Merged
albertvillanova merged 1 commit into
mainfrom
ci-drop-is-github-ci
Aug 17, 2026
Merged

Use built-in GITHUB_ACTIONS variable instead of custom IS_GITHUB_CI#6749
albertvillanova merged 1 commit into
mainfrom
ci-drop-is-github-ci

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Aug 14, 2026

Copy link
Copy Markdown
Member

This PR replaces the custom IS_GITHUB_CI environment variable with the GITHUB_ACTIONS variable that GitHub Actions sets automatically.

Motivation

The slow_tests Make target only writes a pytest report log when running in CI, and this was signalled by an IS_GITHUB_CI variable declared in the slow tests workflow. GitHub Actions already exports GITHUB_ACTIONS=true on every runner, so the custom variable is redundant.

Changes

  • Use GITHUB_ACTIONS instead of IS_GITHUB_CI to enable the pytest report log in the slow_tests Make target
  • Drop the IS_GITHUB_CI environment variable from the slow tests workflow

Note

Low Risk
Small CI/Makefile change with no application or security impact; report logging still only runs when GitHub Actions sets GITHUB_ACTIONS.

Overview
The slow tests workflow no longer sets a custom IS_GITHUB_CI env var. The slow_tests Make target now gates pytest --report-log slow_tests.log on GitHub’s built-in GITHUB_ACTIONS variable instead.

Behavior in Actions should stay the same (report log only in CI); local make slow_tests still skips the report log when GITHUB_ACTIONS is unset.

Reviewed by Cursor Bugbot for commit bfd400f. Bugbot is set up for automated code reviews on this repo. Configure here.

@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
albertvillanova merged commit db2fc64 into main Aug 17, 2026
23 checks passed
@albertvillanova
albertvillanova deleted the ci-drop-is-github-ci branch August 17, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant