Report slow tests results to Slack based on the job status - #6754
Report slow tests results to Slack based on the job status#6754albertvillanova wants to merge 4 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c32dd56. Configure here.
c32dd56 to
176a66f
Compare
|
Ah, for the record, because it's about slow tests: I’ve never felt that the slow tests add much value. Most are redundant with the default tests, and some aren’t actually slow, they’re just labeled as such for some reason. Cleaning this up and seeing whether we can simply drop them has always been a low-priority item in the back of my mind. |
176a66f to
ffb19a7
Compare
ffb19a7 to
906c70d
Compare

Stacked on top of #6753.
This PR makes the slow tests workflow report to Slack based on the job status, using the shared
post-slackaction already used by the other test workflows, and reducesscripts/log_reports.pyto writing the job summary.Motivation
The slow tests workflow posts to Slack from
scripts/log_reports.py, which only sends a message when it finds failed tests in the pytest report log. Any failure that prevents the log from being written, a failed installation, a container killed by the runner, a job timeout, or a pytest startup error, leaves the report empty, so the script sends nothing and the failure goes unnoticed.Reporting the job status instead makes the notification independent of what pytest managed to write, and it is what the other test workflows already do, so the workflows now share a single Slack mechanism.
Solution
Both jobs end with the shared
post-slackaction, passing${{ job.status }}, as intests.yml. The report step keeps generating the job summary, andlog_reports.pyno longer builds Slack payloads, so it no longer needsslack_sdknor theSLACK_API_TOKENvariable. The script also now reports missing and empty log files in the job summary, which were previously only mentioned in the message it failed to send.Changes
post-slackaction, based on the job statusscripts/log_reports.py, keeping the failed tests table and adding the missing and empty log file warnings to the job summarySLACK_API_TOKENenvironment variable withCI_SLACK_CHANNEL, as in the other test workflowsslack_sdkin the report stepsNote for reviewers
The Slack channel now comes from the
CI_PUSH_MAIN_CHANNELsecret, for consistency with the other test workflows, whereasscripts/log_reports.pyhadtrl-push-cihardcoded as a default. Please confirm both point to the same channel.Note
Low Risk
CI and reporting-only changes with no runtime library impact; channel secret alignment with other workflows is the main operational check.
Overview
Slow-test CI now notifies Slack from job status (shared
post-slackaction on both single- and multi-GPU jobs), matchingtests.yml, so failures still alert when pytest never writes a log.scripts/log_reports.pyno longer builds or sends Slack messages: it only prints the GitHub job summary (failed-test tables, pass/no-log warnings). The workflow dropsslack_sdkandSLACK_API_TOKEN, usesCI_PUSH_MAIN_CHANNELviaCI_SLACK_CHANNEL, and keepstabulatefor the summary step.Reviewed by Cursor Bugbot for commit 8897542. Bugbot is set up for automated code reviews on this repo. Configure here.