Rename subset to subview and migrate subview tests to .pto#344
Rename subset to subview and migrate subview tests to .pto#344TaoTao-real wants to merge 10 commits intohw-native-sys:mainfrom
Conversation
|
/run all |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A5 板测失败
失败用例
|
A5 板测失败详情:PR #344xors
xor
vectorAddition
vadd_validshape_hyper
vadd_pto_ir
trap
trans
tinsert
tileSetGetValue
tileScalar
tmatmulk_autosync_a5
test_set_wait_unified_api
test_mem_inject_sync_basic
test_intercore_sync_a5
test_inject_sync_two_event_id
test_inject_sync_loop
test_inject_sync_loop_nest
test_inject_sync_intra_pipe_barrier
test_inject_sync_if
test_inject_sync_if_else
test_dynamic_valid_shape
test_barrier_sync
test_auto_sync_tail_hint
test_a5_buf_sync
sync
syncHigh
rar_optimization_test
nested_loop_confliect
matmul
compensation_test
add_double_dynamic
vadd_pto_pingpong
subview_tsubs
subview
subview_boxed_dynamic
subsc
subs
subc
sub
sqrt
sort32
shrs
shr
shls
shl
set_validshape
sels
sel
scatter
scalar_ptr
rsqrt
rowsum
rowmin
rowmax
rowexpandsub
rowexpandmul
rowexpanddiv
rowexpandadd
rowexpand
reshape
bitcast_inplace_cvt
|
A5 板测失败详情:PR #344bitcast_dtype_alias
rems
rem
relu
recip
vector_example_dag_kernel_mul
vector_example_dag_kernel_add_scalar
vector_example_dag_kernel_add
paged_attention_example_kernel_softmax_prepare
paged_attention_example_kernel_qk_matmul
paged_attention_example_kernel_pv_matmul
paged_attention_example_kernel_online_update
paged_attention_example_kernel_init_inplace
orchestration_example_kernel_mul
orchestration_example_kernel_add_scalar
orchestration_example_kernel_add
print_scalar
prelu
plan_memory_reuse_sequential
plan_memory_peak_exact_capacity
plan_memory_peak_8_overlapping
plan_memory_no_reuse_overlap
plan_memory_nested_loops
plan_memory_loop_no_reuse_outer_live
plan_memory_loop_in_if
plan_memory_if_yield
plan_memory_if_in_loop
plan_memory_fragmentation_two_holes
plan_memory_fragmentation_hole_fit
plan_memory_for_iter_args_yield
plan_memory_bind_tile_alias_liveness
partmin
partmax
partition_view_verify_valid
partition_view_verify_rank_mismatch_valid
partition5d_dynamic_a5
partition5d_a5
partadd
ors
or
not
neg
muls
mul
mscatter
mrgsort_format2
mrgsort_a5
mins
min
mgather
memory
maxs
max
tmatmulk
matMul
lrelu
log
layout_inference
tensor_view_layout_dn
|
A5 板测失败详情:PR #344tensor_view_infer_layout_dn
gatherb
gather
gather_legacy
fillpad
fillpad_expand
expands
expand
exp
elementwise
divs2
divs
div
dataMovement
cvt
concat
cv_region
complex
colsum
colmin
colmax
colexpandsub
colexpandmul
colexpandmin
colexpandmax
colexpanddiv
colexpand
cmps
cmp
ci
bf16_tile
ands
and
addsc
adds
addptr
addptr_f16
addptr_dynamic
addptr_chain
addc
abs
|
A3 板测成功
|
|
已整理 subview 更新内容并同步 PR 描述,当前分支核心语义已明确:PTO/IR 显示逻辑子块大小,EmitC 保持父 tile 物理 shape,子块范围由 valid_row/valid_col 表达。另:A3 board_validation(SubView)已通过 compare。 |
|
针对
Commit: |
b4f33b7 to
bf7e3f7
Compare
bf7e3f7 to
dec6fa0
Compare
Codex Review该评论由 review 机器人自动更新。
Summary发现 2 个 P1: Findings
这个 PR 把 tile 视图 op 的公开名字改成了
这里把 subview 的默认 valid 推导改成了“没有显式 |
Summary
subsettosubview(op class, parser/printer, docs, tests, and call sites).subviewuser-facing type semantics explicit:sizes), e.g.rows=8, cols=8.Tile<..., rows, cols, ...>keeps parent tile shape.valid_row/valid_col..ptoand sample tests to lock the above behavior.Motivation
subview) and remove legacysubsetterminology.Design
SubsetOp->SubViewOppto.subset->pto.subviewSubViewOp::inferReturnTypesbuilds result tile type fromsizes(logical shape).sizesand validatesvalid_row/valid_colbounds.pto.subviewlowers tomemref.subviewthen reinterprets to parent-shape memref.BindTileOp+pto.view_semantics="subview"drives EmitC to materialize fresh tile handle from shifted base address.Testing
ninja -C build ptoastest/basic/subview_*.ptoguard cases pass.test/samples/SubView/board_validationpassed compare (out0/out1/out2/out3).Risk / Rollback
subsetspelling need migration.