IBX-12244: Restored refresh-instead-of-stale for logged-in users on Varnish 7 - #86
Open
vidarl wants to merge 1 commit into
Open
IBX-12244: Restored refresh-instead-of-stale for logged-in users on Varnish 7#86vidarl wants to merge 1 commit into
vidarl wants to merge 1 commit into
Conversation
|
This was referenced Aug 12, 2026
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 12, 2026 13:42
barw4
reviewed
Aug 12, 2026
Comment on lines
+65
to
+66
| // window. varnish5/6.vcl do this in vcl_hit with return (miss), which later versions do not support. | ||
| if (req.http.cookie && std.healthy(req.backend_hint)) { |
Contributor
There was a problem hiding this comment.
Isn't req.http.cookie too broad? Wouldn't it make more sense to narrow it down to req.http.Cookie ~ "eZSESSID" or similar? I would say every user carries some cookie even if not logged or am I missing something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR Depends on #85 so base branch is set to IBX-12241-varnish-cache-behat. However, do not merge into IBX-12241-varnish-cache-behat. Instead it should be merged into 46 once #85 has been merged there.
Description:
varnish5.vclandvarnish6.vclcallsreturn (miss)fromvcl_hitto prevent logged-in usersfrom receiving stale content. Calling
return (miss)fromvcl_hitis not supported in varnish7and later. And the functionality was never ported to the varnish7 vcl.
This caps the grace period per request in
vcl_recvinstead, right after cookie normalisation soonly surviving session cookies count:
For QA:
FYI : Due to #85, there is now a behat test for this specific case:
Documentation: