Skip to content

fix negative input bug#87

Closed
okwme wants to merge 1 commit intoiden3:masterfrom
okwme:master
Closed

fix negative input bug#87
okwme wants to merge 1 commit intoiden3:masterfrom
okwme:master

Conversation

@okwme
Copy link
Contributor

@okwme okwme commented Oct 4, 2023

Same bug as fixed in 0xPARC/zkrepl#13 and effecting use of https://github.com/projectsophon/hardhat-circom. I originally thought it would be fixed by updating the version of circom being used in hardhat as per projectsophon/hardhat-circom#80 but realize the problem is with this library.

@okwme
Copy link
Contributor Author

okwme commented Oct 4, 2023

Hm I just ran into another error with this fix. When I print this.prime in circom_runtime, I get:

21888242844879328548818664213742077600362041385367538672338993241347936223233n

While in circom, p is:

21888242871839275222246405745257275088548364400416034343698204186575808495617n

Why are these different numbers?

@okwme
Copy link
Contributor Author

okwme commented Oct 6, 2023

closing this PR in place of #90 which targets a specific branch of my fork instead of master and addresses the issue of incorrect calculation of p in a separate PR #89

@okwme okwme closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant