fix: Use Uint32Array when calculating prime as is done in circom2#89
Merged
phated merged 1 commit intoiden3:masterfrom Oct 8, 2023
Merged
fix: Use Uint32Array when calculating prime as is done in circom2#89phated merged 1 commit intoiden3:masterfrom
phated merged 1 commit intoiden3:masterfrom
Conversation
Closed
phated
reviewed
Oct 8, 2023
|
|
||
| this.instance.exports.getRawPrime(); | ||
| const arr = new Array(this.n32); | ||
| const arr = new Uint32Array(this.n32); |
Contributor
There was a problem hiding this comment.
Thanks for submitting this. For context, here's the circom2 code: https://github.com/iden3/circom/blob/v2.1.6/code_producers/src/wasm_elements/common/witness_calculator.js#L116
phated
approved these changes
Oct 8, 2023
phated
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pwas incorrectly being calculated as21888242844879328548818664213742077600362041385367538672338993241347936223233ninstead of21888242871839275222246405745257275088548364400416034343698204186575808495617nas referenced in #87. This PR corrects the miscalculation by using an unsigned 32 byte array instead of a standard array.