Jnj templates scripts 4 change column alignment#221
Jnj templates scripts 4 change column alignment#221munoztd0 wants to merge 5 commits intojnj_templates_scriptsfrom
Conversation
Unit Tests Summary 1 files 274 suites 23m 25s ⏱️ For more details on these failures, see this check. Results for commit e57bf17. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit b8a75c1 ♻️ This comment has been updated with latest results. |
| tt_to_tlgrtf(head(result, 100), | ||
| file = fileid, orientation = "landscape", | ||
| alignments = list( | ||
| list(row = 1:100, col = 1:8, value = "left") | ||
| ) | ||
| ) |
There was a problem hiding this comment.
hi @munoztd0 , will this change be called a lot?
There was a problem hiding this comment.
Sorry I don't understand, what do you mean by "called a lot" and which change ? @shajoezhu
There was a problem hiding this comment.
my question was that will this kinda of function call appear in many places, for example, in your other test souce_code?
There was a problem hiding this comment.
Yes these appears at in every test, again this is just a demonstration that you ask to see what would be the difference if we changed a column width..
No I the main PR #209 we pre compute the column width before so we hard coded the column widths so we will never have this change affect the scda tests.
There was a problem hiding this comment.
ok. thanks man. so i guess, we can close this now?
As discussed #209 (comment) in #209
I change column alignment in a listing and a tables (lsfae01 and tsfae09)
This is what it looks like
And for the whole diff here