Adding Jnj templates scripts

[munoztd0]

As discussed we want to integrate JnJ innovative medecine newly release open-source TLG catalog scripts.

Key finding

Across these experiments, we confirmed that RTF snapshot diffs are highly sensitive to computed column widths, resulting in a lot of false positives even when the intended change is only numeric formatting.

Mitigation implemented

To reduce these false positives, I computed the column widths ahead of time and hardcode them into our tests, so width calculation doesn’t fluctuate between runs/changes.

[github-actions]

Unit Tests Summary

  1 files  274 suites   14m 40s ⏱️
411 tests 411 ✅ 0 💤 0 ❌
687 runs  687 ✅ 0 💤 0 ❌

Results for commit 3826377.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
lsfae01	👶		$+0.56$	$+1$	$0$	$0$	$0$
lsfae02	👶		$+0.47$	$+1$	$0$	$0$	$0$
lsfae03	👶		$+0.31$	$+1$	$0$	$0$	$0$
lsfae04	👶		$+0.19$	$+1$	$0$	$0$	$0$
lsfae05	👶		$+0.47$	$+1$	$0$	$0$	$0$
lsfae06a	👶		$+0.41$	$+1$	$0$	$0$	$0$
lsfae06b	👶		$+0.40$	$+1$	$0$	$0$	$0$
lsfdth01	👶		$+0.20$	$+1$	$0$	$0$	$0$
lsfecg01	👶		$+0.73$	$+1$	$0$	$0$	$0$
lsfecg02part1	👶		$+1.78$	$+1$	$0$	$0$	$0$
lsfecg02part2	👶		$+1.45$	$+1$	$0$	$0$	$0$
lsfecg02part3	👶		$+1.49$	$+1$	$0$	$0$	$0$
lsflab01	👶		$+0.53$	$+1$	$0$	$0$	$0$
lsfvit01	👶		$+1.64$	$+1$	$0$	$0$	$0$
lsfvit02	👶		$+2.03$	$+1$	$0$	$0$	$0$
lsicm01	👶		$+0.59$	$+1$	$0$	$0$	$0$
lsidem01	👶		$+0.42$	$+1$	$0$	$0$	$0$
lsidem02	👶		$+0.36$	$+1$	$0$	$0$	$0$
lsids01	👶		$+0.40$	$+1$	$0$	$0$	$0$
lsids02	👶		$+0.40$	$+1$	$0$	$0$	$0$
lsids03	👶		$+0.40$	$+1$	$0$	$0$	$0$
lsids04	👶		$+0.17$	$+1$	$0$	$0$	$0$
lsids05	👶		$+0.13$	$+1$	$0$	$0$	$0$
lsiex01	👶		$+0.45$	$+1$	$0$	$0$	$0$
lsiex02	👶		$+0.35$	$+1$	$0$	$0$	$0$
lsiex03	👶		$+0.49$	$+1$	$0$	$0$	$0$
lsimh01	👶		$+0.42$	$+1$	$0$	$0$	$0$
tpk01a	👶		$+3.59$	$+1$	$0$	$0$	$0$
tpk01bpart1	👶		$+3.25$	$+1$	$0$	$0$	$0$
tpk01bpart2	👶		$+3.29$	$+1$	$0$	$0$	$0$
tpk02part1	👶		$+8.12$	$+1$	$0$	$0$	$0$
tpk02part2	👶		$+8.26$	$+1$	$0$	$0$	$0$
tpk03	👶		$+2.40$	$+1$	$0$	$0$	$0$
tsfae01a	👶		$+1.79$	$+1$	$0$	$0$	$0$
tsfae01b	👶		$+1.83$	$+1$	$0$	$0$	$0$
tsfae02	👶		$+3.47$	$+1$	$0$	$0$	$0$
tsfae02a	👶		$+8.71$	$+1$	$0$	$0$	$0$
tsfae03	👶		$+3.14$	$+1$	$0$	$0$	$0$
tsfae03a	👶		$+7.82$	$+1$	$0$	$0$	$0$
tsfae04	👶		$+2.49$	$+1$	$0$	$0$	$0$
tsfae04a	👶		$+5.61$	$+1$	$0$	$0$	$0$
tsfae05	👶		$+2.32$	$+1$	$0$	$0$	$0$
tsfae05a	👶		$+4.97$	$+1$	$0$	$0$	$0$
tsfae06a	👶		$+5.83$	$+1$	$0$	$0$	$0$
tsfae06b	👶		$+17.86$	$+1$	$0$	$0$	$0$
tsfae07a	👶		$+2.22$	$+1$	$0$	$0$	$0$
tsfae07b	👶		$+2.29$	$+1$	$0$	$0$	$0$
tsfae08	👶		$+2.60$	$+1$	$0$	$0$	$0$
tsfae09	👶		$+0.90$	$+1$	$0$	$0$	$0$
tsfae10	👶		$+5.24$	$+1$	$0$	$0$	$0$
tsfae11	👶		$+2.96$	$+1$	$0$	$0$	$0$
tsfae12	👶		$+2.70$	$+1$	$0$	$0$	$0$
tsfae13	👶		$+2.09$	$+1$	$0$	$0$	$0$
tsfae14	👶		$+4.50$	$+1$	$0$	$0$	$0$
tsfae15	👶		$+2.58$	$+1$	$0$	$0$	$0$
tsfae16part1	👶		$+10.54$	$+1$	$0$	$0$	$0$
tsfae16part2	👶		$+10.66$	$+1$	$0$	$0$	$0$
tsfae17a	👶		$+3.70$	$+1$	$0$	$0$	$0$
tsfae17b	👶		$+2.32$	$+1$	$0$	$0$	$0$
tsfae17c	👶		$+3.73$	$+1$	$0$	$0$	$0$
tsfae17d	👶		$+3.59$	$+1$	$0$	$0$	$0$
tsfae19a	👶		$+0.68$	$+1$	$0$	$0$	$0$
tsfae19b	👶		$+0.66$	$+1$	$0$	$0$	$0$
tsfae19c	👶		$+1.01$	$+1$	$0$	$0$	$0$
tsfae19d	👶		$+1.02$	$+1$	$0$	$0$	$0$
tsfae20a	👶		$+1.40$	$+1$	$0$	$0$	$0$
tsfae20b	👶		$+1.40$	$+1$	$0$	$0$	$0$
tsfae20c	👶		$+1.42$	$+1$	$0$	$0$	$0$
tsfae21apart1	👶		$+8.33$	$+1$	$0$	$0$	$0$
tsfae21apart2	👶		$+8.37$	$+1$	$0$	$0$	$0$
tsfae21apart3	👶		$+8.50$	$+1$	$0$	$0$	$0$
tsfae21apart4	👶		$+8.17$	$+1$	$0$	$0$	$0$
tsfae21bpart1	👶		$+10.79$	$+1$	$0$	$0$	$0$
tsfae21bpart2	👶		$+11.02$	$+1$	$0$	$0$	$0$
tsfae21bpart3	👶		$+10.98$	$+1$	$0$	$0$	$0$
tsfae21bpart4	👶		$+10.72$	$+1$	$0$	$0$	$0$
tsfae21c	👶		$+6.12$	$+1$	$0$	$0$	$0$
tsfae21d	👶		$+7.96$	$+1$	$0$	$0$	$0$
tsfae22apart1	👶		$+9.78$	$+1$	$0$	$0$	$0$
tsfae22apart2	👶		$+9.48$	$+1$	$0$	$0$	$0$
tsfae22apart3	👶		$+9.55$	$+1$	$0$	$0$	$0$
tsfae22apart4	👶		$+9.77$	$+1$	$0$	$0$	$0$
tsfae22bpart1	👶		$+6.16$	$+1$	$0$	$0$	$0$
tsfae22bpart2	👶		$+5.77$	$+1$	$0$	$0$	$0$
tsfae22cpart1	👶		$+8.32$	$+1$	$0$	$0$	$0$
tsfae22cpart2	👶		$+8.39$	$+1$	$0$	$0$	$0$
tsfae22cpart3	👶		$+8.41$	$+1$	$0$	$0$	$0$
tsfae22cpart4	👶		$+8.53$	$+1$	$0$	$0$	$0$
tsfae23a	👶		$+0.85$	$+1$	$0$	$0$	$0$
tsfae23b	👶		$+0.37$	$+1$	$0$	$0$	$0$
tsfae23c	👶		$+0.64$	$+1$	$0$	$0$	$0$
tsfae23d	👶		$+0.86$	$+1$	$0$	$0$	$0$
tsfae24a	👶		$+0.47$	$+1$	$0$	$0$	$0$
tsfae24b	👶		$+0.48$	$+1$	$0$	$0$	$0$
tsfae24c	👶		$+2.52$	$+1$	$0$	$0$	$0$
tsfae24d	👶		$+2.70$	$+1$	$0$	$0$	$0$
tsfae24fpart1	👶		$+12.00$	$+1$	$0$	$0$	$0$
tsfae24fpart2	👶		$+12.39$	$+1$	$0$	$0$	$0$
tsfae24fpart3	👶		$+11.79$	$+1$	$0$	$0$	$0$
tsfdth01	👶		$+1.22$	$+1$	$0$	$0$	$0$
tsfecg01apart1	👶		$+4.56$	$+1$	$0$	$0$	$0$
tsfecg01apart2	👶		$+4.54$	$+1$	$0$	$0$	$0$
tsfecg01apart3	👶		$+4.57$	$+1$	$0$	$0$	$0$
tsfecg01part1	👶		$+9.13$	$+1$	$0$	$0$	$0$
tsfecg01part2	👶		$+8.61$	$+1$	$0$	$0$	$0$
tsfecg02	👶		$+3.03$	$+1$	$0$	$0$	$0$
tsfecg03	👶		$+0.60$	$+1$	$0$	$0$	$0$
tsfecg04	👶		$+2.30$	$+1$	$0$	$0$	$0$
tsfecg05	👶		$+1.28$	$+1$	$0$	$0$	$0$
tsflab01apart1	👶		$+14.60$	$+1$	$0$	$0$	$0$
tsflab01apart2	👶		$+14.44$	$+1$	$0$	$0$	$0$
tsflab01apart3	👶		$+14.44$	$+1$	$0$	$0$	$0$
tsflab01part1	👶		$+6.35$	$+1$	$0$	$0$	$0$
tsflab01part2	👶		$+6.39$	$+1$	$0$	$0$	$0$
tsflab02	👶		$+0.95$	$+1$	$0$	$0$	$0$
tsflab02a	👶		$+2.57$	$+1$	$0$	$0$	$0$
tsflab02b	👶		$+2.14$	$+1$	$0$	$0$	$0$
tsflab03	👶		$+3.40$	$+1$	$0$	$0$	$0$
tsflab03a	👶		$+9.95$	$+1$	$0$	$0$	$0$
tsflab04a	👶		$+2.71$	$+1$	$0$	$0$	$0$
tsflab04b	👶		$+1.14$	$+1$	$0$	$0$	$0$
tsflab05	👶		$+3.16$	$+1$	$0$	$0$	$0$
tsflab06	👶		$+2.98$	$+1$	$0$	$0$	$0$
tsflab07	👶		$+18.18$	$+1$	$0$	$0$	$0$
tsfvit01apart1	👶		$+6.58$	$+1$	$0$	$0$	$0$
tsfvit01apart2	👶		$+6.65$	$+1$	$0$	$0$	$0$
tsfvit01apart3	👶		$+6.73$	$+1$	$0$	$0$	$0$
tsfvit01apart4	👶		$+6.85$	$+1$	$0$	$0$	$0$
tsfvit01part1	👶		$+3.52$	$+1$	$0$	$0$	$0$
tsfvit01part2	👶		$+3.50$	$+1$	$0$	$0$	$0$
tsfvit01part3	👶		$+3.73$	$+1$	$0$	$0$	$0$
tsfvit01part4	👶		$+3.34$	$+1$	$0$	$0$	$0$
tsfvit02	👶		$+0.64$	$+1$	$0$	$0$	$0$
tsfvit03	👶		$+0.63$	$+1$	$0$	$0$	$0$
tsfvit04	👶		$+0.63$	$+1$	$0$	$0$	$0$
tsfvit05	👶		$+1.76$	$+1$	$0$	$0$	$0$
tsfvit06	👶		$+0.57$	$+1$	$0$	$0$	$0$
tsicm01	👶		$+5.41$	$+1$	$0$	$0$	$0$
tsicm02	👶		$+5.40$	$+1$	$0$	$0$	$0$
tsicm03	👶		$+4.21$	$+1$	$0$	$0$	$0$
tsicm04	👶		$+4.25$	$+1$	$0$	$0$	$0$
tsicm05	👶		$+7.09$	$+1$	$0$	$0$	$0$
tsicm06	👶		$+7.00$	$+1$	$0$	$0$	$0$
tsicm07	👶		$+0.66$	$+1$	$0$	$0$	$0$
tsicm08	👶		$+0.67$	$+1$	$0$	$0$	$0$
tsidem01	👶		$+2.30$	$+1$	$0$	$0$	$0$
tsidem02	👶		$+0.76$	$+1$	$0$	$0$	$0$
tsids01	👶		$+0.36$	$+1$	$0$	$0$	$0$
tsids02	👶		$+1.54$	$+1$	$0$	$0$	$0$
tsids02a	👶		$+7.61$	$+1$	$0$	$0$	$0$
tsiex01	👶		$+1.52$	$+1$	$0$	$0$	$0$
tsiex02	👶		$+1.34$	$+1$	$0$	$0$	$0$
tsiex03	👶		$+1.06$	$+1$	$0$	$0$	$0$
tsiex04	👶		$+0.88$	$+1$	$0$	$0$	$0$
tsiex06	👶		$+0.40$	$+1$	$0$	$0$	$0$
tsiex07	👶		$+0.58$	$+1$	$0$	$0$	$0$
tsiex08	👶		$+1.31$	$+1$	$0$	$0$	$0$
tsiex09	👶		$+0.61$	$+1$	$0$	$0$	$0$
tsiex10	👶		$+0.59$	$+1$	$0$	$0$	$0$
tsiex11	👶		$+3.15$	$+1$	$0$	$0$	$0$
tsimh01	👶		$+1.15$	$+1$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
lsfae01	👶		$+0.56$	lsfae01
lsfae02	👶		$+0.47$	lsfae02
lsfae03	👶		$+0.31$	lsfae03
lsfae04	👶		$+0.19$	lsfae04
lsfae05	👶		$+0.47$	lsfae05
lsfae06a	👶		$+0.41$	lsfae06a
lsfae06b	👶		$+0.40$	lsfae06b
lsfdth01	👶		$+0.20$	lsfdth01
lsfecg01	👶		$+0.73$	lsfecg01
lsfecg02part1	👶		$+1.78$	lsfecg02part1of3
lsfecg02part2	👶		$+1.45$	lsfecg02part2of3
lsfecg02part3	👶		$+1.49$	lsfecg02part3of3
lsflab01	👶		$+0.53$	lsflab01
lsfvit01	👶		$+1.64$	lsfvit01
lsfvit02	👶		$+2.03$	lsfvit02
lsicm01	👶		$+0.59$	lsicm01
lsidem01	👶		$+0.42$	lsidem01
lsidem02	👶		$+0.36$	lsidem02
lsids01	👶		$+0.40$	lsids01
lsids02	👶		$+0.40$	lsids02
lsids03	👶		$+0.40$	lsids03
lsids04	👶		$+0.17$	lsids04
lsids05	👶		$+0.13$	lsids05
lsiex01	👶		$+0.45$	lsiex01
lsiex02	👶		$+0.35$	lsiex02
lsiex03	👶		$+0.49$	lsiex03
lsimh01	👶		$+0.42$	lsimh01
tpk01a	👶		$+3.59$	tpk01a
tpk01bpart1	👶		$+3.25$	tpk01bpart1of2
tpk01bpart2	👶		$+3.29$	tpk01bpart2of2
tpk02part1	👶		$+8.12$	tpk02part1of2
tpk02part2	👶		$+8.26$	tpk02part2of2
tpk03	👶		$+2.40$	tpk03
tsfae01a	👶		$+1.79$	tsfae01a
tsfae01b	👶		$+1.83$	tsfae01b
tsfae02	👶		$+3.47$	tsfae02
tsfae02a	👶		$+8.71$	tsfae02a
tsfae03	👶		$+3.14$	tsfae03
tsfae03a	👶		$+7.82$	tsfae03a
tsfae04	👶		$+2.49$	tsfae04
tsfae04a	👶		$+5.61$	tsfae04a
tsfae05	👶		$+2.32$	tsfae05
tsfae05a	👶		$+4.97$	tsfae05a
tsfae06a	👶		$+5.83$	tsfae06a
tsfae06b	👶		$+17.86$	tsfae06b
tsfae07a	👶		$+2.22$	tsfae07a
tsfae07b	👶		$+2.29$	tsfae07b
tsfae08	👶		$+2.60$	tsfae08
tsfae09	👶		$+0.90$	tsfae09
tsfae10	👶		$+5.24$	tsfae10
tsfae11	👶		$+2.96$	tsfae11
tsfae12	👶		$+2.70$	tsfae12
tsfae13	👶		$+2.09$	tsfae13
tsfae14	👶		$+4.50$	tsfae14
tsfae15	👶		$+2.58$	tsfae15
tsfae16part1	👶		$+10.54$	tsfae16part1of2
tsfae16part2	👶		$+10.66$	tsfae16part2of2
tsfae17a	👶		$+3.70$	tsfae17a
tsfae17b	👶		$+2.32$	tsfae17b
tsfae17c	👶		$+3.73$	tsfae17c
tsfae17d	👶		$+3.59$	tsfae17d
tsfae19a	👶		$+0.68$	tsfae19a
tsfae19b	👶		$+0.66$	tsfae19b
tsfae19c	👶		$+1.01$	tsfae19c
tsfae19d	👶		$+1.02$	tsfae19d
tsfae20a	👶		$+1.40$	tsfae20a
tsfae20b	👶		$+1.40$	tsfae20b
tsfae20c	👶		$+1.42$	tsfae20c
tsfae21apart1	👶		$+8.33$	tsfae21apart1of4
tsfae21apart2	👶		$+8.37$	tsfae21apart2of4
tsfae21apart3	👶		$+8.50$	tsfae21apart3of4
tsfae21apart4	👶		$+8.17$	tsfae21apart4of4
tsfae21bpart1	👶		$+10.79$	tsfae21bpart1of4
tsfae21bpart2	👶		$+11.02$	tsfae21bpart2of4
tsfae21bpart3	👶		$+10.98$	tsfae21bpart3of4
tsfae21bpart4	👶		$+10.72$	tsfae21bpart4of4
tsfae21c	👶		$+6.12$	tsfae21c
tsfae21d	👶		$+7.96$	tsfae21d
tsfae22apart1	👶		$+9.78$	tsfae22apart1of4
tsfae22apart2	👶		$+9.48$	tsfae22apart2of4
tsfae22apart3	👶		$+9.55$	tsfae22apart3of4
tsfae22apart4	👶		$+9.77$	tsfae22apart4of4
tsfae22bpart1	👶		$+6.16$	tsfae22bpart1of2
tsfae22bpart2	👶		$+5.77$	tsfae22bpart2of2
tsfae22cpart1	👶		$+8.32$	tsfae22cpart1of4
tsfae22cpart2	👶		$+8.39$	tsfae22cpart2of4
tsfae22cpart3	👶		$+8.41$	tsfae22cpart3of4
tsfae22cpart4	👶		$+8.53$	tsfae22cpart4of4
tsfae23a	👶		$+0.85$	tsfae23a
tsfae23b	👶		$+0.37$	tsfae23b
tsfae23c	👶		$+0.64$	tsfae23c
tsfae23d	👶		$+0.86$	tsfae23d
tsfae24a	👶		$+0.47$	tsfae24a
tsfae24b	👶		$+0.48$	tsfae24b
tsfae24c	👶		$+2.52$	tsfae24c
tsfae24d	👶		$+2.70$	tsfae24d
tsfae24fpart1	👶		$+12.00$	tsfae24fpart1of3
tsfae24fpart2	👶		$+12.39$	tsfae24fpart2of3
tsfae24fpart3	👶		$+11.79$	tsfae24fpart3of3
tsfdth01	👶		$+1.22$	tsfdth01
tsfecg01apart1	👶		$+4.56$	tsfecg01a
tsfecg01apart2	👶		$+4.54$	tsfecg01a
tsfecg01apart3	👶		$+4.57$	tsfecg01a
tsfecg01part1	👶		$+9.13$	tsfecg01
tsfecg01part2	👶		$+8.61$	tsfecg01
tsfecg02	👶		$+3.03$	tsfecg02
tsfecg03	👶		$+0.60$	tsfecg03
tsfecg04	👶		$+2.30$	tsfecg04
tsfecg05	👶		$+1.28$	tsfecg05
tsflab01apart1	👶		$+14.60$	tsflab01a
tsflab01apart2	👶		$+14.44$	tsflab01a
tsflab01apart3	👶		$+14.44$	tsflab01a
tsflab01part1	👶		$+6.35$	tsflab01
tsflab01part2	👶		$+6.39$	tsflab01
tsflab02	👶		$+0.95$	tsflab02
tsflab02a	👶		$+2.57$	tsflab02a
tsflab02b	👶		$+2.14$	tsflab02b
tsflab03	👶		$+3.40$	tsflab03
tsflab03a	👶		$+9.95$	tsflab03a
tsflab04a	👶		$+2.71$	tsflab04a
tsflab04b	👶		$+1.14$	tsflab04b
tsflab05	👶		$+3.16$	tsflab05
tsflab06	👶		$+2.98$	tsflab06
tsflab07	👶		$+18.18$	tsflab07
tsfvit01apart1	👶		$+6.58$	tsfvit01a
tsfvit01apart2	👶		$+6.65$	tsfvit01a
tsfvit01apart3	👶		$+6.73$	tsfvit01a
tsfvit01apart4	👶		$+6.85$	tsfvit01a
tsfvit01part1	👶		$+3.52$	tsfvit01
tsfvit01part2	👶		$+3.50$	tsfvit01
tsfvit01part3	👶		$+3.73$	tsfvit01
tsfvit01part4	👶		$+3.34$	tsfvit01
tsfvit02	👶		$+0.64$	tsfvit02
tsfvit03	👶		$+0.63$	tsfvit03
tsfvit04	👶		$+0.63$	tsfvit04
tsfvit05	👶		$+1.76$	tsfvit05
tsfvit06	👶		$+0.57$	tsfvit06
tsicm01	👶		$+5.41$	tsicm01
tsicm02	👶		$+5.40$	tsicm02
tsicm03	👶		$+4.21$	tsicm03
tsicm04	👶		$+4.25$	tsicm04
tsicm05	👶		$+7.09$	tsicm05
tsicm06	👶		$+7.00$	tsicm06
tsicm07	👶		$+0.66$	tsicm07
tsicm08	👶		$+0.67$	tsicm08
tsidem01	👶		$+2.30$	tsidem01
tsidem02	👶		$+0.76$	tsidem02
tsids01	👶		$+0.36$	tsids01
tsids02	👶		$+1.54$	tsids02
tsids02a	👶		$+7.61$	tsids02a
tsiex01	👶		$+1.52$	tsiex01
tsiex02	👶		$+1.34$	tsiex02
tsiex03	👶		$+1.06$	tsiex03
tsiex04	👶		$+0.88$	tsiex04
tsiex06	👶		$+0.40$	tsiex06
tsiex07	👶		$+0.58$	tsiex07
tsiex08	👶		$+1.31$	tsiex08
tsiex09	👶		$+0.61$	tsiex09
tsiex10	👶		$+0.59$	tsiex10
tsiex11	👶		$+3.15$	tsiex11
tsimh01	👶		$+1.15$	tsimh01

Results for commit 4d40a27

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @munoztd0 , thanks for submitting the PR, i would suggest to snapshot the ascii tables instead of rtf, the table is much more readable for comparing on github, rtf is less ideal in this case. i am guessing you would like to use rtf due to output formatting?

[munoztd0]

hi @munoztd0 , thanks for submitting the PR, i would suggest to snapshot the ascii tables instead of rtf, the table is much more readable for comparing on github, rtf is less ideal in this case. i am guessing you would like to use rtf due to output formatting?

@shajoezhu I 100% agree but you're also right on your guess. If that is a blocker I could put it up the food chain but I have no hope for that.

[munoztd0]

New error on tsfae13 appeared but only on the CRAN pass, still need to investigate

[iaugusty]

@munoztd0
should our table/listing programs be pre-or-suffixed with jnj, like done for test-table_jnj_tbl1?

https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-table_jnj_tbl1.R

[shajoezhu]

i suggest we not include rtf files here. otherwise it is going to fail always if minor changes which is not efficent, and we wont be able to test for anything. i think just create simple static snapshot is good. thanks guys!

[munoztd0]

@munoztd0 should our table/listing programs be pre-or-suffixed with jnj, like done for test-table_jnj_tbl1?

https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-table_jnj_tbl1.R

I could do that but that would be quite a mess and also not have the same names that in internal, but lets discuss it.

[Melkiades]

Thanks for the PR! I would like to echo Joe about rtf files. It seems a bit of a fragile test considering that not everyone has the same rtf software on their machine. I strongly suggest to snapshot-test the final table and not the rtf file. Decoration details can be tested as strings if not included directly in the table.

It is important to have readable snapshots as possible changes are easier to understand and review that way. Furthermore, simple changes may have a large line changes count that would add to the .git file size. Reducing that size down after some time would be a non-trivial task.

[munoztd0]

Thanks for the PR! I would like to echo Joe about rtf files. It seems a bit of a fragile test considering that not everyone has the same rtf software on their machine. I strongly suggest to snapshot-test the final table and not the rtf file. Decoration details can be tested as strings if not included directly in the table.

It is important to have readable snapshots as possible changes are easier to understand and review that way. Furthermore, simple changes may have a large line changes count that would add to the .git file size. Reducing that size down after some time would be a non-trivial task.

I 100% agree, I will try to discuss that internally and see if I can make a case for it.. Changing the PR to draft for now,

[gmbecker]

Hi @shajoezhu @Melkiades,

The rtf files are snapshotted as text, rather than as binary files. Specifically with

expect_snapshot_file(compare = compare_file_text, ...

Note this prevents issues issues with OS-specific line endings (guess why this is how we test them...). This should prevent the most egregious case of .git bloat you're worried about.

Furthermore, these files are not generated by third party libraries with OS-specific behaviors, but rather by concatenation of strings in {tidytlg} (this has its own issues, and I have ... feelings about it, but exact text brittleness is not one of them).

The issue with just testing the table is that the because J&J doesn't use ASCII for their submissions, the table is insufficient to prevent regressions from our submission-requirement specs. If I had my way this wouldn't be an issue but it's multiple orders of magnitude above my pay grade and simply put, 100% not going to change.

I'd like to provisionally include the rtf files in the tests and then if we are getting (unexpected) changes we can take the full snapshots out and fall back to an imperfect backup plan.

My issue with doing string checking for the (unfortunately for us) mandatory decorations/formatting is that that is likely to be substantially more brittle and prone to false negatives (ie tests passing when they shouldn't) than the snapshot tests. We can keep this in our pocket as a back up, as I alluded to above, but I'd like to try the better solution first, with the expectation that it won't have the .git bloat issue.

Let me know what you think. I'll also discuss this with you, Joe, when we meet next if desired.

[shajoezhu]

hi @gmbecker and @munoztd0 , I would like to request the following test, and better understand the limitation (if there is any) using rtf and see how much impact that the future result

I would like to propose several tests and branch off from this jnj_templates_scripts, and propose merge request, and see the differences of changes

1. lets change the format of a calculation in one of the template, let's say rounding from 2 decimal places to 3 decimal places, and how it will result in the rtf output
2. create a feature branch in tern, let's say change the default format of a statistics to 3 decimal places. and i expect numbers to change in both roche and jnj template, and and i want to see how much changes this can cause
3. create a feature branch in formatters, let's say you want to change a column width of something, how much diff it can cause
4. change the column alignment, and see how much it can change

or above should be in 4 seperate branches, so it would be eaiser for us to investigate

[shajoezhu]

hi @munoztd0 @gmbecker , thanks a lot for working on the issue. I see there was a lot of changes, and things are still moving, and testing. once you are ready, we can take a look, and discuss next steps. thanks

[shajoezhu]

hi @munoztd0 , thanks for the PRs, I can see you have put in a lot of efforts into these test cases. i was wodnering if you can update with your rtf snapshot changes please?

[munoztd0]

Hi @gmbecker and @shajoezhu, thanks for the detailed set of proposed tests.

First off: sorry for the mess/noise and all the notifications. Managing multiple PRs plus the CI/CD runs ended up being a bit of a nightmare 😅, but I’ve now completed the requested investigations and kept each experiment isolated to make review easier.

PRs created (one per test)

1) Template-level rounding change decimals

• PR: Jnj templates scripts 1 change rtf decimals #216
• What I changed: updated a template decimal format.
• Outcome: the RTF diff shows the expected decimal change, but it also introduced an artifact: changes in column widths, which creates “false positive” diffs.
• Notes: I added diffs + screenshots directly in the PR to show both the true change and the width-related noise.

---

2) tern feature branch: changed all defaults statistic formats

• PR: Jnj templates scripts 2a **tern** change default decimals  #217
• What I changed: adjusted tern defaults.
• Outcome: this did affect some of our RTF outputs initially (as expected).
• Follow-up: we updated/fixed our side so that tern default formatting no longer impacts our tests, and the suite is stable again.
• Notes: details and CI logs are in the PR.

---

3) formatters feature branch: column width change

• PR: Jnj templates scripts 3 formatters change width #220
• What I changed: attempted multiple column-width modifications in formatters.
• Outcome: these changes do not impact our RTF snapshots, apparently because we don’t rely on those width settings in our snapshot tests (so none of our tests fail).
• However: Roche’s pipeline/tests did fail as expected, which aligns with the hypothesis that their snapshot setup is more sensitive to those formatters width changes.
• Notes: full context is included in the PR.

---

4) Column alignment changes (listing + table)

• PR: Jnj templates scripts 4 change column alignment #221
• What I changed: modified column alignment in:
  • a listing: lsfae01 and a table: tsfae09
• Outcome: alignment changes produce visible diffs; screenshots + diff artifacts are in the PR.

---

Key finding

Across these experiments, we confirmed that RTF snapshot diffs are highly sensitive to computed column widths, resulting in a lot of false positives even when the intended change is only numeric formatting.

Mitigation implemented

To reduce these false positives, I computed the column widths ahead of time and hardcode them into our tests, so width calculation doesn’t fluctuate between runs/changes.

5) “True positive” example PR (coming)

• PR: Jnj templates scripts 5 true positive #225
• Goal: demonstrate a true positive diff (e.g., changing some data) that results in only cell-level changes, not spurious column-width diffs.

---

Thanks again — each PR contains detailed diffs, screenshots, and pipeline logs to make review easier.

[shajoezhu]

hi @munoztd0 , this is the final PR i think? can you please fix the style. thanks

[munoztd0]

hi @munoztd0 , this is the final PR i think? can you please fix the style. thanks

Yes indeed, I rebased on main, cleaned up commits history and reran the pipelines, everything good now @gmbecker @shajoezhu @Melkiades