Skip to content

Jnj templates scripts 5 true positive#225

Closed
munoztd0 wants to merge 2 commits intojnj_templates_scriptsfrom
jnj_templates_scripts_5_true_positive
Closed

Jnj templates scripts 5 true positive#225
munoztd0 wants to merge 2 commits intojnj_templates_scriptsfrom
jnj_templates_scripts_5_true_positive

Conversation

@munoztd0
Copy link
Collaborator

@munoztd0 munoztd0 commented Mar 6, 2026

See #209

This is the a final extra PR to show the improvements we done to fence off spurious column widths changes by "precomputing" the column widths beforehand and "hardcoding" them into the tests/templates.

Goal: demonstrate a true positive diff (e.g., changing some formats is tsids01) that results in only cell-level changes, not spurious column-width diffs.

This is the only diff we get now from changing some formats is tsids01
image

https://github.com/insightsengineering/scda.test/actions/runs/22768812763/job/66043787143

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Unit Tests Summary

  1 files  274 suites   14m 14s ⏱️
411 tests 219 ✅ 192 💤 0 ❌
676 runs  267 ✅ 409 💤 0 ❌

Results for commit b209e46.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
lsfae01 👶 $+0.56$ $+1$ $+1$ $0$ $0$
lsfae02 👶 $+0.43$ $+1$ $+1$ $0$ $0$
lsfae03 👶 $+0.31$ $+1$ $+1$ $0$ $0$
lsfae04 👶 $+0.18$ $+1$ $+1$ $0$ $0$
lsfae05 👶 $+0.46$ $+1$ $+1$ $0$ $0$
lsfae06a 👶 $+0.39$ $+1$ $+1$ $0$ $0$
lsfae06b 👶 $+0.39$ $+1$ $+1$ $0$ $0$
lsfdth01 👶 $+0.20$ $+1$ $+1$ $0$ $0$
lsfecg01 👶 $+0.72$ $+1$ $+1$ $0$ $0$
lsfecg02part1 👶 $+1.68$ $+1$ $+1$ $0$ $0$
lsfecg02part2 👶 $+1.40$ $+1$ $+1$ $0$ $0$
lsfecg02part3 👶 $+1.46$ $+1$ $+1$ $0$ $0$
lsflab01 👶 $+0.52$ $+1$ $+1$ $0$ $0$
lsfvit01 👶 $+1.59$ $+1$ $+1$ $0$ $0$
lsfvit02 👶 $+2.02$ $+1$ $+1$ $0$ $0$
lsicm01 👶 $+0.61$ $+1$ $+1$ $0$ $0$
lsidem01 👶 $+0.41$ $+1$ $+1$ $0$ $0$
lsidem02 👶 $+0.35$ $+1$ $+1$ $0$ $0$
lsids01 👶 $+0.37$ $+1$ $+1$ $0$ $0$
lsids02 👶 $+0.38$ $+1$ $+1$ $0$ $0$
lsids03 👶 $+0.39$ $+1$ $+1$ $0$ $0$
lsids04 👶 $+0.16$ $+1$ $+1$ $0$ $0$
lsids05 👶 $+0.11$ $+1$ $+1$ $0$ $0$
lsiex01 👶 $+0.44$ $+1$ $+1$ $0$ $0$
lsiex02 👶 $+0.33$ $+1$ $+1$ $0$ $0$
lsiex03 👶 $+0.47$ $+1$ $+1$ $0$ $0$
lsimh01 👶 $+0.44$ $+1$ $+1$ $0$ $0$
table_lbt14 💚 $33.12$ $-2.20$ $0$ $0$ $0$ $0$
tpk01a 👶 $+3.66$ $+1$ $+1$ $0$ $0$
tpk01bpart1 👶 $+3.30$ $+1$ $+1$ $0$ $0$
tpk01bpart2 👶 $+3.35$ $+1$ $+1$ $0$ $0$
tpk02part1 👶 $+8.33$ $+1$ $+1$ $0$ $0$
tpk02part2 👶 $+7.78$ $+1$ $+1$ $0$ $0$
tpk03 👶 $+2.33$ $+1$ $+1$ $0$ $0$
tsfae01a 👶 $+1.72$ $+1$ $+1$ $0$ $0$
tsfae01b 👶 $+1.74$ $+1$ $+1$ $0$ $0$
tsfae02 👶 $+3.11$ $+1$ $+1$ $0$ $0$
tsfae02a 👶 $+8.84$ $+1$ $+1$ $0$ $0$
tsfae03 👶 $+3.09$ $+1$ $+1$ $0$ $0$
tsfae03a 👶 $+8.01$ $+1$ $+1$ $0$ $0$
tsfae04 👶 $+2.35$ $+1$ $+1$ $0$ $0$
tsfae04a 👶 $+5.38$ $+1$ $+1$ $0$ $0$
tsfae05 👶 $+2.25$ $+1$ $+1$ $0$ $0$
tsfae05a 👶 $+4.68$ $+1$ $+1$ $0$ $0$
tsfae06a 👶 $+5.57$ $+1$ $+1$ $0$ $0$
tsfae06b 👶 $+18.18$ $+1$ $+1$ $0$ $0$
tsfae07a 👶 $+2.15$ $+1$ $+1$ $0$ $0$
tsfae07b 👶 $+2.19$ $+1$ $+1$ $0$ $0$
tsfae08 👶 $+2.54$ $+1$ $+1$ $0$ $0$
tsfae09 👶 $+0.89$ $+1$ $+1$ $0$ $0$
tsfae10 👶 $+5.13$ $+1$ $+1$ $0$ $0$
tsfae11 👶 $+2.62$ $+1$ $+1$ $0$ $0$
tsfae12 👶 $+2.71$ $+1$ $+1$ $0$ $0$
tsfae13 👶 $+2.12$ $+1$ $+1$ $0$ $0$
tsfae14 👶 $+4.45$ $+1$ $+1$ $0$ $0$
tsfae15 👶 $+2.54$ $+1$ $+1$ $0$ $0$
tsfae16part1 👶 $+10.33$ $+1$ $+1$ $0$ $0$
tsfae16part2 👶 $+10.11$ $+1$ $+1$ $0$ $0$
tsfae17a 👶 $+3.21$ $+1$ $+1$ $0$ $0$
tsfae17b 👶 $+2.30$ $+1$ $+1$ $0$ $0$
tsfae17c 👶 $+3.71$ $+1$ $+1$ $0$ $0$
tsfae17d 👶 $+3.51$ $+1$ $+1$ $0$ $0$
tsfae19a 👶 $+0.66$ $+1$ $+1$ $0$ $0$
tsfae19b 👶 $+0.67$ $+1$ $+1$ $0$ $0$
tsfae19c 👶 $+1.00$ $+1$ $+1$ $0$ $0$
tsfae19d 👶 $+1.23$ $+1$ $+1$ $0$ $0$
tsfae20a 👶 $+1.34$ $+1$ $+1$ $0$ $0$
tsfae20b 👶 $+1.34$ $+1$ $+1$ $0$ $0$
tsfae20c 👶 $+1.33$ $+1$ $+1$ $0$ $0$
tsfae21apart1 👶 $+7.88$ $+1$ $+1$ $0$ $0$
tsfae21apart2 👶 $+7.95$ $+1$ $+1$ $0$ $0$
tsfae21apart3 👶 $+7.99$ $+1$ $+1$ $0$ $0$
tsfae21apart4 👶 $+8.24$ $+1$ $+1$ $0$ $0$
tsfae21bpart1 👶 $+10.38$ $+1$ $+1$ $0$ $0$
tsfae21bpart2 👶 $+10.54$ $+1$ $+1$ $0$ $0$
tsfae21bpart3 👶 $+10.64$ $+1$ $+1$ $0$ $0$
tsfae21bpart4 👶 $+10.64$ $+1$ $+1$ $0$ $0$
tsfae21c 👶 $+5.87$ $+1$ $+1$ $0$ $0$
tsfae21d 👶 $+7.59$ $+1$ $+1$ $0$ $0$
tsfae22apart1 👶 $+9.45$ $+1$ $+1$ $0$ $0$
tsfae22apart2 👶 $+9.41$ $+1$ $+1$ $0$ $0$
tsfae22apart3 👶 $+9.18$ $+1$ $+1$ $0$ $0$
tsfae22apart4 👶 $+9.33$ $+1$ $+1$ $0$ $0$
tsfae22bpart1 👶 $+5.81$ $+1$ $+1$ $0$ $0$
tsfae22bpart2 👶 $+5.92$ $+1$ $+1$ $0$ $0$
tsfae22cpart1 👶 $+8.02$ $+1$ $+1$ $0$ $0$
tsfae22cpart2 👶 $+8.13$ $+1$ $+1$ $0$ $0$
tsfae22cpart3 👶 $+8.16$ $+1$ $+1$ $0$ $0$
tsfae22cpart4 👶 $+8.44$ $+1$ $+1$ $0$ $0$
tsfae23a 👶 $+0.83$ $+1$ $+1$ $0$ $0$
tsfae23b 👶 $+0.36$ $+1$ $+1$ $0$ $0$
tsfae23c 👶 $+0.62$ $+1$ $+1$ $0$ $0$
tsfae23d 👶 $+0.85$ $+1$ $+1$ $0$ $0$
tsfae24a 👶 $+0.46$ $+1$ $+1$ $0$ $0$
tsfae24b 👶 $+0.49$ $+1$ $+1$ $0$ $0$
tsfae24c 👶 $+2.52$ $+1$ $+1$ $0$ $0$
tsfae24d 👶 $+2.65$ $+1$ $+1$ $0$ $0$
tsfae24fpart1 👶 $+11.77$ $+1$ $+1$ $0$ $0$
tsfae24fpart2 👶 $+11.97$ $+1$ $+1$ $0$ $0$
tsfae24fpart3 👶 $+11.85$ $+1$ $+1$ $0$ $0$
tsfdth01 👶 $+1.23$ $+1$ $+1$ $0$ $0$
tsfecg01apart1 👶 $+4.49$ $+1$ $+1$ $0$ $0$
tsfecg01apart2 👶 $+4.53$ $+1$ $+1$ $0$ $0$
tsfecg01apart3 👶 $+4.59$ $+1$ $+1$ $0$ $0$
tsfecg01part1 👶 $+9.08$ $+1$ $+1$ $0$ $0$
tsfecg01part2 👶 $+8.47$ $+1$ $+1$ $0$ $0$
tsfecg02 👶 $+3.01$ $+1$ $+1$ $0$ $0$
tsfecg03 👶 $+0.59$ $+1$ $+1$ $0$ $0$
tsfecg04 👶 $+2.29$ $+1$ $+1$ $0$ $0$
tsfecg05 👶 $+1.28$ $+1$ $+1$ $0$ $0$
tsflab01apart1 👶 $+14.50$ $+1$ $+1$ $0$ $0$
tsflab01apart2 👶 $+14.18$ $+1$ $+1$ $0$ $0$
tsflab01apart3 👶 $+14.24$ $+1$ $+1$ $0$ $0$
tsflab01part1 👶 $+6.25$ $+1$ $+1$ $0$ $0$
tsflab01part2 👶 $+6.26$ $+1$ $+1$ $0$ $0$
tsflab02 👶 $+0.97$ $+1$ $+1$ $0$ $0$
tsflab02a 👶 $+2.56$ $+1$ $+1$ $0$ $0$
tsflab02b 👶 $+2.13$ $+1$ $+1$ $0$ $0$
tsflab03 👶 $+3.38$ $+1$ $+1$ $0$ $0$
tsflab03a 👶 $+10.13$ $+1$ $+1$ $0$ $0$
tsflab04a 👶 $+2.52$ $+1$ $+1$ $0$ $0$
tsflab04b 👶 $+1.05$ $+1$ $+1$ $0$ $0$
tsflab05 👶 $+2.76$ $+1$ $+1$ $0$ $0$
tsflab06 👶 $+3.05$ $+1$ $+1$ $0$ $0$
tsflab07 👶 $+17.11$ $+1$ $+1$ $0$ $0$
tsfvit01apart1 👶 $+6.51$ $+1$ $+1$ $0$ $0$
tsfvit01apart2 👶 $+6.62$ $+1$ $+1$ $0$ $0$
tsfvit01apart3 👶 $+6.75$ $+1$ $+1$ $0$ $0$
tsfvit01apart4 👶 $+7.08$ $+1$ $+1$ $0$ $0$
tsfvit01part1 👶 $+3.35$ $+1$ $+1$ $0$ $0$
tsfvit01part2 👶 $+3.39$ $+1$ $+1$ $0$ $0$
tsfvit01part3 👶 $+3.35$ $+1$ $+1$ $0$ $0$
tsfvit01part4 👶 $+3.37$ $+1$ $+1$ $0$ $0$
tsfvit02 👶 $+0.65$ $+1$ $+1$ $0$ $0$
tsfvit03 👶 $+0.63$ $+1$ $+1$ $0$ $0$
tsfvit04 👶 $+0.63$ $+1$ $+1$ $0$ $0$
tsfvit05 👶 $+1.82$ $+1$ $+1$ $0$ $0$
tsfvit06 👶 $+0.58$ $+1$ $+1$ $0$ $0$
tsicm01 👶 $+5.35$ $+1$ $+1$ $0$ $0$
tsicm02 👶 $+5.46$ $+1$ $+1$ $0$ $0$
tsicm03 👶 $+4.21$ $+1$ $+1$ $0$ $0$
tsicm04 👶 $+4.34$ $+1$ $+1$ $0$ $0$
tsicm05 👶 $+6.63$ $+1$ $+1$ $0$ $0$
tsicm06 👶 $+6.74$ $+1$ $+1$ $0$ $0$
tsicm07 👶 $+0.67$ $+1$ $+1$ $0$ $0$
tsicm08 👶 $+0.66$ $+1$ $+1$ $0$ $0$
tsidem01 👶 $+2.29$ $+1$ $+1$ $0$ $0$
tsidem02 👶 $+0.75$ $+1$ $+1$ $0$ $0$
tsids01 👶 $+0.37$ $+1$ $+1$ $0$ $0$
tsids02 👶 $+1.51$ $+1$ $+1$ $0$ $0$
tsids02a 👶 $+7.58$ $+1$ $+1$ $0$ $0$
tsiex01 👶 $+1.49$ $+1$ $+1$ $0$ $0$
tsiex02 👶 $+1.59$ $+1$ $+1$ $0$ $0$
tsiex03 👶 $+0.99$ $+1$ $+1$ $0$ $0$
tsiex04 👶 $+0.82$ $+1$ $+1$ $0$ $0$
tsiex06 👶 $+0.40$ $+1$ $+1$ $0$ $0$
tsiex07 👶 $+0.56$ $+1$ $+1$ $0$ $0$
tsiex08 👶 $+1.23$ $+1$ $+1$ $0$ $0$
tsiex09 👶 $+0.60$ $+1$ $+1$ $0$ $0$
tsiex10 👶 $+0.59$ $+1$ $+1$ $0$ $0$
tsiex11 👶 $+2.96$ $+1$ $+1$ $0$ $0$
tsimh01 👶 $+1.10$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
lsfae01 👶 $+0.56$ lsfae01
lsfae02 👶 $+0.43$ lsfae02
lsfae03 👶 $+0.31$ lsfae03
lsfae04 👶 $+0.18$ lsfae04
lsfae05 👶 $+0.46$ lsfae05
lsfae06a 👶 $+0.39$ lsfae06a
lsfae06b 👶 $+0.39$ lsfae06b
lsfdth01 👶 $+0.20$ lsfdth01
lsfecg01 👶 $+0.72$ lsfecg01
lsfecg02part1 👶 $+1.68$ lsfecg02part1of3
lsfecg02part2 👶 $+1.40$ lsfecg02part2of3
lsfecg02part3 👶 $+1.46$ lsfecg02part3of3
lsflab01 👶 $+0.52$ lsflab01
lsfvit01 👶 $+1.59$ lsfvit01
lsfvit02 👶 $+2.02$ lsfvit02
lsicm01 👶 $+0.61$ lsicm01
lsidem01 👶 $+0.41$ lsidem01
lsidem02 👶 $+0.35$ lsidem02
lsids01 👶 $+0.37$ lsids01
lsids02 👶 $+0.38$ lsids02
lsids03 👶 $+0.39$ lsids03
lsids04 👶 $+0.16$ lsids04
lsids05 👶 $+0.11$ lsids05
lsiex01 👶 $+0.44$ lsiex01
lsiex02 👶 $+0.33$ lsiex02
lsiex03 👶 $+0.47$ lsiex03
lsimh01 👶 $+0.44$ lsimh01
table_lbt14 💚 $7.00$ $-1.19$ LBT14_variant_2_LOW_works_as_expected
tpk01a 👶 $+3.66$ tpk01a
tpk01bpart1 👶 $+3.30$ tpk01bpart1of2
tpk01bpart2 👶 $+3.35$ tpk01bpart2of2
tpk02part1 👶 $+8.33$ tpk02part1of2
tpk02part2 👶 $+7.78$ tpk02part2of2
tpk03 👶 $+2.33$ tpk03
tsfae01a 👶 $+1.72$ tsfae01a
tsfae01b 👶 $+1.74$ tsfae01b
tsfae02 👶 $+3.11$ tsfae02
tsfae02a 👶 $+8.84$ tsfae02a
tsfae03 👶 $+3.09$ tsfae03
tsfae03a 👶 $+8.01$ tsfae03a
tsfae04 👶 $+2.35$ tsfae04
tsfae04a 👶 $+5.38$ tsfae04a
tsfae05 👶 $+2.25$ tsfae05
tsfae05a 👶 $+4.68$ tsfae05a
tsfae06a 👶 $+5.57$ tsfae06a
tsfae06b 👶 $+18.18$ tsfae06b
tsfae07a 👶 $+2.15$ tsfae07a
tsfae07b 👶 $+2.19$ tsfae07b
tsfae08 👶 $+2.54$ tsfae08
tsfae09 👶 $+0.89$ tsfae09
tsfae10 👶 $+5.13$ tsfae10
tsfae11 👶 $+2.62$ tsfae11
tsfae12 👶 $+2.71$ tsfae12
tsfae13 👶 $+2.12$ tsfae13
tsfae14 👶 $+4.45$ tsfae14
tsfae15 👶 $+2.54$ tsfae15
tsfae16part1 👶 $+10.33$ tsfae16part1of2
tsfae16part2 👶 $+10.11$ tsfae16part2of2
tsfae17a 👶 $+3.21$ tsfae17a
tsfae17b 👶 $+2.30$ tsfae17b
tsfae17c 👶 $+3.71$ tsfae17c
tsfae17d 👶 $+3.51$ tsfae17d
tsfae19a 👶 $+0.66$ tsfae19a
tsfae19b 👶 $+0.67$ tsfae19b
tsfae19c 👶 $+1.00$ tsfae19c
tsfae19d 👶 $+1.23$ tsfae19d
tsfae20a 👶 $+1.34$ tsfae20a
tsfae20b 👶 $+1.34$ tsfae20b
tsfae20c 👶 $+1.33$ tsfae20c
tsfae21apart1 👶 $+7.88$ tsfae21apart1of4
tsfae21apart2 👶 $+7.95$ tsfae21apart2of4
tsfae21apart3 👶 $+7.99$ tsfae21apart3of4
tsfae21apart4 👶 $+8.24$ tsfae21apart4of4
tsfae21bpart1 👶 $+10.38$ tsfae21bpart1of4
tsfae21bpart2 👶 $+10.54$ tsfae21bpart2of4
tsfae21bpart3 👶 $+10.64$ tsfae21bpart3of4
tsfae21bpart4 👶 $+10.64$ tsfae21bpart4of4
tsfae21c 👶 $+5.87$ tsfae21c
tsfae21d 👶 $+7.59$ tsfae21d
tsfae22apart1 👶 $+9.45$ tsfae22apart1of4
tsfae22apart2 👶 $+9.41$ tsfae22apart2of4
tsfae22apart3 👶 $+9.18$ tsfae22apart3of4
tsfae22apart4 👶 $+9.33$ tsfae22apart4of4
tsfae22bpart1 👶 $+5.81$ tsfae22bpart1of2
tsfae22bpart2 👶 $+5.92$ tsfae22bpart2of2
tsfae22cpart1 👶 $+8.02$ tsfae22cpart1of4
tsfae22cpart2 👶 $+8.13$ tsfae22cpart2of4
tsfae22cpart3 👶 $+8.16$ tsfae22cpart3of4
tsfae22cpart4 👶 $+8.44$ tsfae22cpart4of4
tsfae23a 👶 $+0.83$ tsfae23a
tsfae23b 👶 $+0.36$ tsfae23b
tsfae23c 👶 $+0.62$ tsfae23c
tsfae23d 👶 $+0.85$ tsfae23d
tsfae24a 👶 $+0.46$ tsfae24a
tsfae24b 👶 $+0.49$ tsfae24b
tsfae24c 👶 $+2.52$ tsfae24c
tsfae24d 👶 $+2.65$ tsfae24d
tsfae24fpart1 👶 $+11.77$ tsfae24fpart1of3
tsfae24fpart2 👶 $+11.97$ tsfae24fpart2of3
tsfae24fpart3 👶 $+11.85$ tsfae24fpart3of3
tsfdth01 👶 $+1.23$ tsfdth01
tsfecg01apart1 👶 $+4.49$ tsfecg01a
tsfecg01apart2 👶 $+4.53$ tsfecg01a
tsfecg01apart3 👶 $+4.59$ tsfecg01a
tsfecg01part1 👶 $+9.08$ tsfecg01
tsfecg01part2 👶 $+8.47$ tsfecg01
tsfecg02 👶 $+3.01$ tsfecg02
tsfecg03 👶 $+0.59$ tsfecg03
tsfecg04 👶 $+2.29$ tsfecg04
tsfecg05 👶 $+1.28$ tsfecg05
tsflab01apart1 👶 $+14.50$ tsflab01a
tsflab01apart2 👶 $+14.18$ tsflab01a
tsflab01apart3 👶 $+14.24$ tsflab01a
tsflab01part1 👶 $+6.25$ tsflab01
tsflab01part2 👶 $+6.26$ tsflab01
tsflab02 👶 $+0.97$ tsflab02
tsflab02a 👶 $+2.56$ tsflab02a
tsflab02b 👶 $+2.13$ tsflab02b
tsflab03 👶 $+3.38$ tsflab03
tsflab03a 👶 $+10.13$ tsflab03a
tsflab04a 👶 $+2.52$ tsflab04a
tsflab04b 👶 $+1.05$ tsflab04b
tsflab05 👶 $+2.76$ tsflab05
tsflab06 👶 $+3.05$ tsflab06
tsflab07 👶 $+17.11$ tsflab07
tsfvit01apart1 👶 $+6.51$ tsfvit01a
tsfvit01apart2 👶 $+6.62$ tsfvit01a
tsfvit01apart3 👶 $+6.75$ tsfvit01a
tsfvit01apart4 👶 $+7.08$ tsfvit01a
tsfvit01part1 👶 $+3.35$ tsfvit01
tsfvit01part2 👶 $+3.39$ tsfvit01
tsfvit01part3 👶 $+3.35$ tsfvit01
tsfvit01part4 👶 $+3.37$ tsfvit01
tsfvit02 👶 $+0.65$ tsfvit02
tsfvit03 👶 $+0.63$ tsfvit03
tsfvit04 👶 $+0.63$ tsfvit04
tsfvit05 👶 $+1.82$ tsfvit05
tsfvit06 👶 $+0.58$ tsfvit06
tsicm01 👶 $+5.35$ tsicm01
tsicm02 👶 $+5.46$ tsicm02
tsicm03 👶 $+4.21$ tsicm03
tsicm04 👶 $+4.34$ tsicm04
tsicm05 👶 $+6.63$ tsicm05
tsicm06 👶 $+6.74$ tsicm06
tsicm07 👶 $+0.67$ tsicm07
tsicm08 👶 $+0.66$ tsicm08
tsidem01 👶 $+2.29$ tsidem01
tsidem02 👶 $+0.75$ tsidem02
tsids01 👶 $+0.37$ tsids01
tsids02 👶 $+1.51$ tsids02
tsids02a 👶 $+7.58$ tsids02a
tsiex01 👶 $+1.49$ tsiex01
tsiex02 👶 $+1.59$ tsiex02
tsiex03 👶 $+0.99$ tsiex03
tsiex04 👶 $+0.82$ tsiex04
tsiex06 👶 $+0.40$ tsiex06
tsiex07 👶 $+0.56$ tsiex07
tsiex08 👶 $+1.23$ tsiex08
tsiex09 👶 $+0.60$ tsiex09
tsiex10 👶 $+0.59$ tsiex10
tsiex11 👶 $+2.96$ tsiex11
tsimh01 👶 $+1.10$ tsimh01

Results for commit 565be16

♻️ This comment has been updated with latest results.

@munoztd0 munoztd0 changed the base branch from main to jnj_templates_scripts March 6, 2026 15:31
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@munoztd0 just wondering why no changes in rtf here? saw that one was there in the PR comment?

@munoztd0
Copy link
Collaborator Author

munoztd0 commented Mar 9, 2026

@munoztd0 just wondering why no changes in rtf here? saw that one was there in the PR comment?

Hey @Melkiades , not sure I follow your question. So I will recap to see if that clears things out.

  • I change some formats in the template/test
  • This is supposed to create a failed test , which it does
  • Then what I show in the comment is just the diff using testthat::snapshot_review() just a you would to evaluate snapshot changes
  • The only differences there is with regular snapshot testing is that our source of truth is the .rtf not the .md in _snaps

So this is a "mock" PR to show what would the testthat::snapshot_review() look like if we got to have formats changes, so that why I don't change any rtf in this PR.

Hope this answer to you question but please let me know if I totally went sideways.

@shajoezhu
Copy link
Contributor

if we change the colwidth here, just a single number, that will blow up everything right?

@munoztd0
Copy link
Collaborator Author

if we change the colwidth here, just a single number, that will blow up everything right?

That is true

@shajoezhu
Copy link
Contributor

hi @munoztd0 , is this PR still intend to merge in? or shall we close.

@Melkiades
Copy link
Contributor

hi @munoztd0 , is this PR still intend to merge in? or shall we close.

I think it is not meant to be merged in but still there are no snapshot changes while I would expect that if the decoration of rtf is still to consider relevant beyond the content

@shajoezhu
Copy link
Contributor

shajoezhu commented Mar 19, 2026

my discussion with @gmbecker , was that the colwidth column widths will be fixed. otherwise the whole thing will fail, anyway, these snapshot should be dead and fixed, the content, number changes detction is essential.

@munoztd0 munoztd0 marked this pull request as draft March 19, 2026 09:48
@munoztd0
Copy link
Collaborator Author

@shajoezhu @Melkiades Indeed none of these PRs where meant to be merged they are feature branches to show you what would happen if some specific scenarios would be happening, but all the actual fixes are in #209

@munoztd0 munoztd0 closed this Mar 19, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants