This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][MATRIX] Adding test cases for testing get_coord() feature.#1676
Merged
[SYCL][MATRIX] Adding test cases for testing get_coord() feature.#1676
Conversation
Currently, the tests are marked for failure, they will pass once the ICG backend suppport is there.
arnamoy10
changed the title
dkhaldi
reviewed
Mar 22, 2023
dkhaldi
left a comment
dkhaldi
left a comment
There was a problem hiding this comment.
Tests look good but the XMX8 versions are missing.
Author
Added those tests |
againull
approved these changes
Mar 23, 2023
Nuullll
reviewed
Mar 27, 2023
|
|
||
| // Calculation of global index | ||
| int sg_idx = (int)global_idy / SG_SZ; | ||
| global_index = col + sg_idx * 4 /*VNNI_FACTOR*/ * SG_SZ; |
There was a problem hiding this comment.
Should this line be global_index = col * 4 + row % 4 + sg_idx * 4 /*VNNI_FACTOR*/ * SG_SZ; instead?
[row, col] are the coordinates within the non-VNNIed subgroup matrix (32x16). I think we need to map [row, col] back to VNNIed indices when summing columns.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the tests are marked for failure, they will pass once the ICG
backend support is there.
The header file support is in this PR: intel/llvm#7851