[SYCL][Matrix] Add initial get_coord API#7851
Conversation
|
We recently added support for the unified matrix API. the one you are using now in matrix-jit.hpp is an old API. |
927c183 to
ca05b4c
Compare
Done with changes. |
|
LGTM. Just had a few minor comments. |
MrSidims
left a comment
There was a problem hiding this comment.
(SPIR-V) Headers are LGTM
c37debe to
4d615e8
Compare
|
Test-suite PR: intel/llvm-test-suite#1676 |
dkhaldi
left a comment
There was a problem hiding this comment.
LGTM.
Minor: remove comment on line 195
Done |
|
@intel/llvm-reviewers-runtime Please take a look and merge if it looks good. Thanks |
dm-vodopyanov
left a comment
There was a problem hiding this comment.
@arnamoy10, please, update description with proper wording, e.g., what this patch introduces/etc
Updated, thank you. |
|
@intel/llvm-gatekeepers , help merge this patch please? |
|
Failed Tests (1): Unrelated to this patch. Issue: #8766 |
This patch adds an initial API for the retrieval of coordinates from a work item element. A
get_coord()method is added to the intel namespace to work onwi_elementclass. Also, a relevant SPIRV op is added, which the get_coord() gets lowered to.This is recreated PR from my forked repo. The discussions are in the original (closed) PR #7037