-
Notifications
You must be signed in to change notification settings - Fork 0
parse json as such #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
parse json as such #379
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [flake8] | ||
| max-imports = 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import io | ||
| import json | ||
|
|
||
| from yaml_ld.document_parsers.base import ( | ||
| BaseDocumentParser, | ||
| DocumentLoaderOptions, | ||
| ) | ||
| from yaml_ld.errors import ( | ||
| DocumentIsScalar, | ||
| InvalidEncoding, | ||
| LoadingDocumentFailed, | ||
| ) | ||
| from yaml_ld.models import JsonLdRecord | ||
|
|
||
|
|
||
| def ensure_not_scalar(document) -> JsonLdRecord | list[JsonLdRecord]: | ||
| """Ensure document is not a scalar value.""" | ||
| if not isinstance(document, (dict, list)): | ||
| raise DocumentIsScalar(document) | ||
|
|
||
| return document | ||
|
|
||
|
|
||
| class JSONDocumentParser(BaseDocumentParser): | ||
| """Parse JSON and JSON-LD documents.""" | ||
|
|
||
| def __call__( | ||
| self, | ||
| data_stream: io.BytesIO, | ||
| source: str, | ||
| options: DocumentLoaderOptions, | ||
| ) -> JsonLdRecord | list[JsonLdRecord]: | ||
| """Parse JSON document into LD.""" | ||
| try: | ||
| text = data_stream.read().decode('utf-8') | ||
| except UnicodeDecodeError as unicode_decode_error: | ||
| raise InvalidEncoding() from unicode_decode_error | ||
|
|
||
| try: | ||
| document = json.loads(text) | ||
| except json.JSONDecodeError as json_error: | ||
| raise LoadingDocumentFailed(path=source) from json_error | ||
|
|
||
| return ensure_not_scalar(document) | ||
anatoly-scherbakov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated
ensure_not_scalarfunction already existsMedium Severity
The
ensure_not_scalarfunction is duplicated. An identical implementation already exists inyaml_ld/document_parsers/yaml_parser.py(lines 25-30). Themarkdown_parser.pyalready imports and uses the existing function fromyaml_parser.py, which is the correct pattern to follow.