Merged
Conversation
- Add missing .val-bad CSS class (below-threshold values were unstyled) - Add touch event handlers to chart for mobile tooltip interaction - Replace bare "No data" text with rich empty state (icon, guidance, CTA) - Remove decorative hover effect from chart card - Show elapsed time counter on Run button during speedtest execution - Use CSS tokens for chart grid lines and fonts (fixes light mode) - Fix tooltip viewport overflow with edge detection - Cache signal detail fetches to avoid redundant API calls - Add i18n keys for empty state in EN/DE/FR/ES - Build tooltip content with DOM methods instead of innerHTML
- Clear _signalCache on history reload (unbounded growth) - Add vertical tooltip edge detection (mobile bottom-edge clipping) - Add touchcancel handler (tooltip could stay visible) - Move .val-bad to main.css alongside .val-warn/.val-crit (available even when speedtest module is disabled) - Remove dead td.textContent assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all findings from a design critique of the speedtest view:
Bug fixes:
.val-badCSS class -- below-threshold download/upload values were being classified in JS but never styled (invisible to users)rgba(255,255,255,0.07)-- invisible in light mode, now uses--border-subtletokenmonospaceinstead of--font-monotokenUX improvements:
Cleanup:
Test plan