Add tests for fromJson response handling#39
Merged
Conversation
Added two new test cases to JsonRpcMessageTest.php: - testFromJsonWithResultField: Ensures fromJson correctly parses a JSON-RPC response containing a 'result' field. - testFromJsonWithErrorField: Ensures fromJson correctly parses a JSON-RPC response containing an 'error' field. These tests specifically cover the conditional branch in JsonRpcMessage::fromJson that handles messages with either 'result' or 'error' keys, improving code coverage for response message parsing.
🧪 Test Results SummaryPHPUnit Tests✅ All tests passed! Details: OK (206 tests, 864 assertions)
Code Quality
📁 Detailed Reports
This comment will update automatically when you push new commits. Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new test cases to JsonRpcMessageTest.php:
These tests specifically cover the conditional branch in JsonRpcMessage::fromJson that handles messages with either 'result' or 'error' keys, improving code coverage for response message parsing.