Skip to content

Add tests for fromJson response handling #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james2037 merged 1 commit into from
Jun 4, 2025
Merged

Add tests for fromJson response handling #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/Message/JsonRpcMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,4 +335,28 @@ public function testToResponseArrayForNotificationThrowsException(): void
$this->expectExceptionMessage('Message is not a response or error, cannot convert to response array.');
$message->toResponseArray();
}

public function testFromJsonWithResultField(): void
{
$json = '{"jsonrpc":"2.0","result":{"data":"success"},"id":"res-123"}';
$message = JsonRpcMessage::fromJson($json);

$this->assertSame('res-123', $message->id);
$this->assertSame(['data' => 'success'], $message->result);
$this->assertSame('', $message->method);
$this->assertNull($message->params);
$this->assertNull($message->error);
}

public function testFromJsonWithErrorField(): void
{
$json = '{"jsonrpc":"2.0","error":{"code":-32600,"message":"Invalid Request"},"id":"err-456"}';
$message = JsonRpcMessage::fromJson($json);

$this->assertSame('err-456', $message->id);
$this->assertSame(['code' => -32600, 'message' => 'Invalid Request'], $message->error);
$this->assertSame('', $message->method);
$this->assertNull($message->params);
$this->assertNull($message->result);
}
}