I've improved the code coverage for the JsonRpcMessage class.#40
Merged
Conversation
I added specific test cases to ensure full coverage of branches within the `fromJson` and `jsonSerialize` methods.
The following branches were targeted:
fromJson:
- `!array_key_exists('id', $data)`: I ensured that responses or errors missing an 'id' field are handled. I added `testFromJsonResponseMissingId` and `testFromJsonErrorResponseMissingId`.
- `!is_array($data['error'])`: I ensured that error messages with a non-array 'error' field are handled. I added `testFromJsonErrorFieldNotAnArray`.
jsonSerialize:
- `$this->id !== null` (for requests/notifications): I ensured that the 'id' field is correctly serialized for messages that are requests (i.e., have an ID and are not errors/results). I added `testJsonSerializeRequestWithId` for explicit coverage, complementing existing indirect coverage.
All new and existing tests pass, and linters are clean.
🧪 Test Results SummaryPHPUnit Tests✅ All tests passed! Details: OK (210 tests, 878 assertions)
Code Quality
📁 Detailed Reports
This comment will update automatically when you push new commits. Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added specific test cases to ensure full coverage of branches within the
fromJsonandjsonSerializemethods.The following branches were targeted:
fromJson:
!array_key_exists('id', $data): I ensured that responses or errors missing an 'id' field are handled. I addedtestFromJsonResponseMissingIdandtestFromJsonErrorResponseMissingId.!is_array($data['error']): I ensured that error messages with a non-array 'error' field are handled. I addedtestFromJsonErrorFieldNotAnArray.jsonSerialize:
$this->id !== null(for requests/notifications): I ensured that the 'id' field is correctly serialized for messages that are requests (i.e., have an ID and are not errors/results). I addedtestJsonSerializeRequestWithIdfor explicit coverage, complementing existing indirect coverage.All new and existing tests pass, and linters are clean.