Skip to content

I've improved the code coverage for the JsonRpcMessage class. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james2037 merged 1 commit into from
Jun 4, 2025
Merged

I've improved the code coverage for the JsonRpcMessage class. #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions tests/Message/JsonRpcMessageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,4 +359,50 @@ public function testFromJsonWithErrorField(): void
$this->assertNull($message->params);
$this->assertNull($message->result);
}

public function testFromJsonResponseMissingId(): void
{
// This JSON represents a result response but is missing the 'id' field.
$json = '{"jsonrpc": "2.0", "result": {"foo": "bar"}}';
$this->expectException(\RuntimeException::class);
$this->expectExceptionCode(JsonRpcMessage::INVALID_REQUEST);
$this->expectExceptionMessage('Response must include ID (even if null for some error cases as per spec, this implementation expects it)');
JsonRpcMessage::fromJson($json);
}

public function testFromJsonErrorResponseMissingId(): void
{
// This JSON represents an error response but is missing the 'id' field.
$json = '{"jsonrpc": "2.0", "error": {"code": -32600, "message": "Invalid Request"}}';
$this->expectException(\RuntimeException::class);
$this->expectExceptionCode(JsonRpcMessage::INVALID_REQUEST);
$this->expectExceptionMessage('Response must include ID (even if null for some error cases as per spec, this implementation expects it)');
JsonRpcMessage::fromJson($json);
}

public function testFromJsonErrorFieldNotAnArray(): void
{
// This JSON represents an error response, but the 'error' field is a string, not an object/array.
$json = '{"jsonrpc": "2.0", "error": "This should be an error object", "id": "err-789"}';
$this->expectException(\RuntimeException::class);
$this->expectExceptionCode(JsonRpcMessage::INVALID_REQUEST);
$this->expectExceptionMessage('Invalid error object in JSON-RPC response');
JsonRpcMessage::fromJson($json);
}

public function testJsonSerializeRequestWithId(): void
{
$message = new JsonRpcMessage('test.request', ['foo' => 'bar'], 'req-789');
// Ensure it's treated as a request by jsonSerialize, not result/error
$message->result = null;
$message->error = null;

$serialized = $message->jsonSerialize();

$this->assertArrayHasKey('id', $serialized);
$this->assertEquals('req-789', $serialized['id']);
$this->assertEquals('test.request', $serialized['method']);
$this->assertEquals(['foo' => 'bar'], $serialized['params']);
$this->assertEquals('2.0', $serialized['jsonrpc']);
}
}