Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to resolve iOS simulator build issues by adjusting build parameters in the NuGet build workflow.
- Removed the explicit exclusion of the arm64 architecture for the iOS simulator build.
- Clarified build configuration for compatibility with various simulator architectures.
Files not reviewed (1)
- SDWebImage-dotnet.csproj: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/build-nuget.yml:69
- Removing the exclusion of 'arm64' may inadvertently allow builds including arm64 for simulators, potentially causing issues on certain architectures. Consider verifying the intended supported architectures or adding an inline comment for clarification.
EXCLUDED_ARCHS="arm64"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.