Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6051c49
build fo arm64 in simulator too
jonathanantoine Apr 18, 2025
a7cdfea
updated to v5
jonathanantoine Apr 18, 2025
a026575
do not create device build
jonathanantoine Apr 18, 2025
534a0d0
build only simulator
jonathanantoine Apr 18, 2025
1f8b58f
framework creation and usage for binding
jonathanantoine Apr 18, 2025
c6b5c20
Do not exclude arch...
jonathanantoine Apr 18, 2025
918aa11
create xarchive
jonathanantoine Apr 18, 2025
d0e2749
ask archive
jonathanantoine Apr 18, 2025
dfdefc5
fix attempt
jonathanantoine Apr 18, 2025
40d482d
remove space
jonathanantoine Apr 18, 2025
366066c
fix attempt
jonathanantoine Apr 18, 2025
53deffa
use target
jonathanantoine Apr 18, 2025
2c3b16a
no archive path
jonathanantoine Apr 18, 2025
b8720a1
try anotehr indent
jonathanantoine Apr 18, 2025
c692b95
build ofr device too
jonathanantoine Apr 18, 2025
2d1636c
upload
jonathanantoine Apr 18, 2025
f180eb2
yse archivePath
jonathanantoine Apr 18, 2025
090039c
exportArchive
jonathanantoine Apr 18, 2025
52568c6
exportOptionsPlist
jonathanantoine Apr 18, 2025
48c36d1
add archivePath
jonathanantoine Apr 18, 2025
9534465
archive path first
jonathanantoine Apr 18, 2025
f5e176c
buuild framework
jonathanantoine Apr 18, 2025
959624a
use xcframework
jonathanantoine Apr 18, 2025
b142806
Rename artifact
jonathanantoine Apr 18, 2025
0797c5c
create filtered framework
jonathanantoine Apr 18, 2025
80733e7
add missing \
jonathanantoine Apr 18, 2025
2432b41
updated README.md
jonathanantoine Apr 18, 2025
be411d6
add compatiblity in readme Compatibility
jonathanantoine Apr 18, 2025
04d5f03
code cleaning
jonathanantoine Apr 18, 2025
7ddc5e7
Fix link me attribute
jonathanantoine Apr 18, 2025
7055d33
remove useless file
jonathanantoine Apr 18, 2025
9b5d0bc
rename artifacts
jonathanantoine Apr 18, 2025
968ad10
Rename tasks of the build
jonathanantoine Apr 18, 2025
367981d
No more upload full framework
jonathanantoine Apr 18, 2025
e3d3517
Update versions
jonathanantoine Apr 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 21 additions & 33 deletions .github/workflows/build-nuget.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,32 +60,28 @@ jobs:
start_line=$((LINE_NUMBER - 2))
end_line=$((LINE_NUMBER + 2))
sed -n "${start_line},${end_line}p" "$FILE_PATH" || echo "Avertissement: Moins de lignes que prévu pour la vérification."
- name: Build SDWebImage for simulator

- name: Build FULL xcframework
run: |
xcodebuild -project ${{ env.SRC_FOLDER }}/${{ env.PROJ_NAME }} \
-target "SDWebImage static" \
-sdk iphonesimulator${{ env.SDK }} \
IPHONEOS_DEPLOYMENT_TARGET=12.2 \
EXCLUDED_ARCHS="arm64"

- name: Build SDWebImage for device
run: |
xcodebuild -project ${{ env.SRC_FOLDER }}/${{ env.PROJ_NAME }} \
-configuration Release \
-target "SDWebImage static" \
-sdk iphoneos${{ env.SDK }} \
IPHONEOS_DEPLOYMENT_TARGET=12.2


- name: Create universal lib with lipo
xcodebuild -project ${{ env.SRC_FOLDER }}/${{ env.PROJ_NAME }} \
-target "SDWebImage XCFramework" \


- name: Build ios/ios-simulator xcframework
run: |
lipo -create \
${{ env.SRC_FOLDER }}/build/Release-iphoneos/libSDWebImage.a \
${{ env.SRC_FOLDER }}/build/Release-iphonesimulator/libSDWebImage.a \
-output ./libSDWebImage.a
lipo -info ./libSDWebImage.a

xcodebuild -create-xcframework \
-framework "${{ env.SRC_FOLDER }}/build/iOS/SDWebImage.framework" \
-framework "${{ env.SRC_FOLDER }}/build/iOSSimulator/SDWebImage.framework" \
-output ./SDWebImage.xcframework

- name: Upload final framework as artifact
uses: actions/upload-artifact@v4.6.2
with:
name: final-framework
compression-level: '0'
path:
./SDWebImage.xcframework

- name: Install .NET 9
uses: actions/setup-dotnet@v4
with:
Expand All @@ -103,15 +99,7 @@ jobs:
- name: Upload .nupkg as artifact
uses: actions/upload-artifact@v4.6.2
with:
name: nuget-package
name: SDWebImage-nuget-package
compression-level: '0'
path:
/Users/runner/work/SDWebImage-dotnet/SDWebImage-dotnet/bin/Release/*.nupkg

- name: Upload .a files as artifact
uses: actions/upload-artifact@v4.6.2
with:
name: native-libs-iphoneos
compression-level: '0'
path:
${{ env.SRC_FOLDER }}/build/Release-iphoneos/**
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![NuGet version](https://badge.fury.io/nu/com.jonathanantoine.SDWebImage.svg)](https://badge.fury.io/nu/com.jonathanantoine.SDWebImage)

- Native library: [SDWebImage](https://github.com/SDWebImage/SDWebImage)
- Native library repository: [SDWebImage](https://github.com/SDWebImage/SDWebImage)

**Support Net 9.0 for iOS (works with Xcode 15 and iOS 17)**

Expand All @@ -11,8 +11,10 @@
* `Install-Package com.jonathanantoine.SDWebImage`
* <https://www.nuget.org/packages/com.jonathanantoine.SDWebImage>

## Build
## Compatibility
* Run on ios and ios simulator (arm64 + x86_64).

## Build
* Run the GitHub action to build the project


Expand Down
6 changes: 3 additions & 3 deletions SDWebImage-dotnet.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<!-- Nuget package -->
<PackageId>com.jonathanantoine.SDWebImage</PackageId>
<Version>5.21.0.4</Version>
<Version>5.21.0.6</Version>
<Authors>Jonathan Antoine</Authors>
<Title>SDWebImage for dotnet</Title>
<PackageProjectUrl>https://github.com/jonathanantoine/SDWebImage-dotnet</PackageProjectUrl>
Expand All @@ -27,8 +27,8 @@
<None Include="README.md" Pack="true" PackagePath="\"/>
</ItemGroup>
<ItemGroup>
<NativeReference Include="libSDWebImage.a">
<Kind>Static</Kind>
<NativeReference Include="SDWebImage.xcframework">
<Kind>Framework</Kind>
<Frameworks>Foundation ImageIO CoreGraphics QuartzCore</Frameworks>
<SmartLink>True</SmartLink>
<ForceLoad>True</ForceLoad>
Expand Down
5 changes: 0 additions & 5 deletions libSDWebImage.linkwith.cs

This file was deleted.

Loading