Fix phpstan errors, and some refactoring#612
Open
mahmoudmagdy1-1 wants to merge 4 commits intojoomla-extensions:5.x-devfrom
Open
Fix phpstan errors, and some refactoring#612mahmoudmagdy1-1 wants to merge 4 commits intojoomla-extensions:5.x-devfrom
mahmoudmagdy1-1 wants to merge 4 commits intojoomla-extensions:5.x-devfrom
Conversation
mahmoudmagdy1-1
force-pushed
the
phpstan_fix
branch
from
fd44180 to
078f2df
Compare
Contributor
Author
|
I marked it initially as draft because I thought there was a problem with my code, but the Cypress tests in build fail because of the Joomla new update, |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #606 .
Summary of Changes
I've fixed all of phpstan errors, refactored to match new Joomla standards and replaced the deprecated methods calls
BEFORE the PR:
AFTER the PR:
Testing Instructions
Run phpstan using this command
./vendor/bin/phpstan(you can also check from drone ci)Expected result
No errors in phpstan, no deperecated methods used
Actual result
some errors in phpstan, and old deperecated methods used
Documentation Changes Required