Skip to content

Skip Nmap on empty Masscan results; handle TCP/UDP-only scans; fix ping args #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jph4cks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip Nmap on empty Masscan results; handle TCP/UDP-only scans; fix ping args #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions jpscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ def main():
for ip in targets:
## first run Masscan on all target ports to get list of open ports
target_ports = masscan(ip,port_range,rate,interface,wait,ipv6)
if not target_ports:
print(f"[-] No open ports found for {ip}, skipping nmap scans")
continue
## then run nmap with those custome ports
output = nmap_scan(target_ports)
# Run Vulnerablity Scan
Expand Down Expand Up @@ -130,23 +133,22 @@ def website_bruteforce(target):
def nmap_vuln_scan(target_ports):
output = {}
for ip in target_ports:
ports = []
udp_ports = []
for port in target_ports[ip]['tcp']:
ports.append(port)
ports = list(target_ports[ip].get('tcp', []))
udp_ports = list(target_ports[ip].get('udp', []))
if not ports and not udp_ports:
continue
#print(ports)
tcpports = ','.join(ports)
#print("tcp ports: "+tcpports)
if len(target_ports[ip])>1:
if ports and udp_ports:
## this means that there are UDP ports too
for port in target_ports[ip]['udp']:
udp_ports.append(port)
#print(udp_ports)
udpports = ','.join(udp_ports)
#print("udp ports: "+udpports)
cmd = "nmap -sUSVC --script vuln -T4 -pT:{0},U:{2} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-vuln-scan".format(tcpports,ip,udpports)
else:
elif ports:
cmd = "nmap -sSVC --script vuln -T4 -pT:{0} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-vuln-scan".format(",".join(ports),ip)
else:
cmd = "nmap -sUSVC --script vuln -T4 -pU:{0} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-vuln-scan".format(",".join(udp_ports),ip)
print("--------------------------------------------")
print("[+] Executing: "+cmd)
nmap = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
Expand All @@ -161,23 +163,22 @@ def nmap_scan(target_ports):
arr = ['udp','tcp']
location = 55 #aprox default location of version
for ip in target_ports:
ports = []
udp_ports = []
for port in target_ports[ip]['tcp']:
ports.append(port)
ports = list(target_ports[ip].get('tcp', []))
udp_ports = list(target_ports[ip].get('udp', []))
if not ports and not udp_ports:
continue
#print(ports)
tcpports = ','.join(ports)
#print("tcp ports: "+tcpports)
if len(target_ports[ip])>1:
if ports and udp_ports:
## this means that there are UDP ports too
for port in target_ports[ip]['udp']:
udp_ports.append(port)
#print(udp_ports)
udpports = ','.join(udp_ports)
#print("udp ports: "+udpports)
cmd = "nmap -A -sU -T4 -pT:{0},U:{2} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-full-scan".format(tcpports,ip,udpports)
else:
elif ports:
cmd = "nmap -A -T4 -pT:{0} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-full-scan".format(",".join(ports),ip)
else:
cmd = "nmap -A -sU -T4 -pU:{0} {1} -Pn -n --open -vvv --min-hostgroup 10 --min-parallelism 100 -oA {1}-full-scan".format(",".join(udp_ports),ip)
print("--------------------------------------------")
print("[+] Executing: "+cmd)
nmap = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)
Expand Down Expand Up @@ -215,7 +216,7 @@ def nmap_scan(target_ports):

def get_mac(IP):
try:
ping = Popen(["ping","-c 1", IP], stdout=PIPE)
ping = Popen(["ping", "-c", "1", IP], stdout=PIPE)
time.sleep(.500)
pid = Popen(["arp", "-n", IP], stdout=PIPE)
s = str(pid.communicate()[0])
Expand Down