[codex] Fix async conversation restore decoding and add targeted unit tests#36
Draft
jskoiz wants to merge 1 commit into
Draft
[codex] Fix async conversation restore decoding and add targeted unit tests#36jskoiz wants to merge 1 commit into
jskoiz wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
@codex review please run a code review on the latest PR head. |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
Codex review pass: I did not find a blocking issue in this pass. Caveat: I did not run local tests; I reviewed the ISO-8601 restore fix and targeted tests, but PR checks only show GitGuardian/Vercel-style checks, not the documented xcodebuild test lane. |
jskoiz
force-pushed
the
agent/build-bootstrap
branch
from
8006a9c to
7448145
Compare
jskoiz
force-pushed
the
codex/test-foundation
branch
from
263a09b to
5074909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Yemma4Teststarget plus focused regression tests for conversation restore and streaming renderingPreferenceKey.defaultValueSwift 6 fix needed for this test branch to build standaloneWhy
Task 04 called for a real test foundation plus the restore bugfix. The restore path was decoding persisted timestamps inconsistently, and the repo needed a repeatable place to pin that behavior with tests.
Impact
Conversation history restore is more reliable, and there is now a focused branch-local test surface for persistence and rendering regressions.
Validation
./scripts/bootstrap_mlx_swift_lm.shbuild-ios-appssimulator build succeeded forYemma4onYemma Preview 17 Pro Max (iOS Simulator 26.4)build-ios-appspackage-workspace tests passed:3/3