fix(helm): ensure tools deployment honors release name

[onematchfox]

Replacement for #1192 since that seems to have gone stale.

Fixes #1190

[Copilot]

Pull request overview

This PR fixes a bug where the kagent-tools Helm sub-chart was ignoring the Helm release name due to a hardcoded fullnameOverride: kagent-tools in the parent chart's default values. This caused the service to always be named kagent-tools instead of {{ .Release.Name }}-tools, leading to DNS resolution failures when the release name was not kagent.

Changes:

• Removes fullnameOverride: kagent-tools which was hardcoding the sub-chart's service name
• Adds nameOverride: tools so the sub-chart generates its service name as {{ .Release.Name }}-tools, properly honoring the Helm release name

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[onematchfox]

@EItanya Heads-up, this change does result in the labels of the kagent-tools deployment being changed which leads to the following error when running Helm upgrade. Sorry, about that!

Error: UPGRADE FAILED: cannot patch "kagent-tools" with kind Deployment: Deployment.apps "kagent-tools" is invalid: spec.selector: Invalid value: {"matchLabels":{"app.kubernetes.io/instance":"kagent","app.kubernetes.io/name":"tools"}}: field is immutable

I personally don't have an issue recreating the Deployment but it might be worth mentioning this in the release notes?

[onematchfox]

P.S. This is ultimately be the cause of #1427 (not sure how that person managed to upgrade the deployment but not the service). And... upgrading the subchart to include kagent-dev/tools#47 will also address the issue and prevent the need to recreate the deployment.

[EItanya]

P.S. This is ultimately be the cause of #1427 (not sure how that person managed to upgrade the deployment but not the service). And... upgrading the subchart to include kagent-dev/tools#47 will also address the issue and prevent the need to recreate the deployment.

I will release tools and then do a new release of kagent.

[onematchfox]

Thanks. And sorry again for the break + extra work