Closed
Conversation
…diDeviceState Replaced unsafe fixed byte arrays with explicit byte fields for all MIDI note and control inputs. This ensures consistent struct layout and correct InputSystem offsets under IL2CPP builds. Previously, IL2CPP was misaligning fixed buffers, causing MIDI note and control paths (note037 → note124) to read incorrect memory offsets. The new explicit layout guarantees stable bindings across Mono and IL2CPP backends.
Author
|
Accidentally closed... new PR: #44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
IL2CPP builds are changing the note paths causing mapping issues with Input Actions in Unity's new Input System. This makes it seem like input isn't working in builds when building for IL2CPP.
Solution:
Replaced unsafe fixed byte arrays with explicit byte fields for all MIDI note and control inputs.
This ensures consistent struct layout and correct InputSystem offsets under IL2CPP builds.
Previously, IL2CPP was misaligning fixed buffers, causing MIDI note and control paths (note037 → note124) to read incorrect memory offsets. The new explicit layout guarantees stable bindings across Mono and IL2CPP backends.