fix: polygon filter for point layers with geojson column mode (#3278)#3321
Open
pierreeurope wants to merge 1 commit intokeplergl:masterfrom
Open
fix: polygon filter for point layers with geojson column mode (#3278)#3321pierreeurope wants to merge 1 commit intokeplergl:masterfrom
pierreeurope wants to merge 1 commit intokeplergl:masterfrom
Conversation
…gl#3278) When filtering by drawing a polygon, point layers using geojson column mode would crash because the position accessor expected array-format data but received {index, dataContainer} objects from the filter pipeline. Fix by using pre-parsed coordinates from dataToFeature when the layer is in geojson column mode, instead of calling the raw position accessor which doesn't support the filter data format. Signed-off-by: pierreeurope <pierre.europe@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3278
When using point layers with geojson column mode (e.g., CSV with WKT point columns like
POINT (7.63 45.04)), drawing a polygon/rectangle filter would crash with:Root Cause
The polygon filter pipeline passes data as
{index, dataContainer}objects, but the geojson column mode's position accessor (geojsonPosAccessor) expects array-format data (row as array) and triesd[geojson.fieldIdx], which returnsundefinedfor objects.Fix
For point layers in geojson column mode, the polygon filter now uses the pre-parsed coordinates from
layer.dataToFeature(which are computed duringupdateLayerMeta) instead of calling the raw position accessor. This avoids the format mismatch entirely and is more efficient since the coordinates are already parsed.Testing
POINT (lng lat)