Skip to content

fix: polygon filter for point layers with geojson column mode (#3278) #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierreeurope wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: polygon filter for point layers with geojson column mode (#3278) #3321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/utils/src/filter-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,16 @@ export const getPolygonFilterFunctor = (layer, filter, dataContainer) => {
switch (layer.type) {
case LAYER_TYPES.point:
case LAYER_TYPES.icon:
// For geojson column mode, coordinates are pre-parsed in dataToFeature
if (layer.dataToFeature && layer.config?.columnMode === 'geojson') {
return data => {
const pos = layer.dataToFeature[data.index];
// pos can be [lng, lat] for Point, or [[lng, lat], ...] for MultiPoint
if (!pos) return false;
const coords = Array.isArray(pos[0]) ? pos[0] : pos;
return coords.every(Number.isFinite) && isInPolygon(coords, filter.value);
};
}
return data => {
const pos = getPosition(data);
return pos.every(Number.isFinite) && isInPolygon(pos, filter.value);
Expand Down