Support Parallel computing#71
Conversation
|
thanks @geertvandeweyer cfor the PR. I am aware of it just found no time yet to look deeper into it. Maybe you can give some more explanations what was the intention with the rule specific threding limits. |
visze
left a comment
There was a problem hiding this comment.
I really like your effort on the ressources. I have to look depper into that. But it seems to be very good. But since there are more side changes it is difficult to me to merge the whole PR
Sorry for the late reply. The rule specific threading was setup rather empirically. Some threads used high memory, so there thatwas limit (hence the resource scaling); for others (I think vep), it was mainly disk I/O. So the rules I had max'd out my SSD setup. Any higher for those would bring I/O into massive wait states... I'm not saying it's a good for all set, but it might be worth adding options to tune the threading per step somehow ? |
fixes related to empty infiles, no valid variants, memory etc
This PR includes:
For benchmarking, see : https://hub.docker.com/repository/docker/cmgantwerpen/cadd/general