Add --max-fdr export filter; use FDR-significant catalog as network universe - #369
Add --max-fdr export filter; use FDR-significant catalog as network universe#369kordk wants to merge 1 commit into
Conversation
…niverse Add --max-fdr to exportBipartiteNetwork.py filtering fdr_est <= max-fdr before top-K ranking, mirroring the --max-boot-p structure (present-column check, warn-and-skip when absent, surviving-count log). NaN fdr_est rows are excluded while the filter is active. Switch pipelinePost.sh stage 4 to --max-fdr 0.05 with NETWORK_TOP_K raised to 100000 as a non-binding safety cap, dropping the --max-boot-p usage. Five forced-fail-validated tests added; existing export and visualization suites kept green. Co-authored-by: kordk <17866388+kordk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Add --max-fdr to exportBipartiteNetwork.py filtering fdr_est <= max-fdr
before top-K ranking, mirroring the --max-boot-p structure (present-column
check, warn-and-skip when absent, surviving-count log). NaN fdr_est rows
are excluded while the filter is active. Switch pipelinePost.sh stage 4
to --max-fdr 0.05 with NETWORK_TOP_K raised to 100000 as a non-binding
safety cap, dropping the --max-boot-p usage. Five forced-fail-validated
tests added; existing export and visualization suites kept green.
PR created automatically by Jules for task 23711287651244282 started by @kordk