Fix shard distribution bias: restore default expiration, add WithMaxKeyLength docs, and getShardID tests#150
Merged
kpango merged 2 commits intobugfix/shard-distribution-biasfrom Feb 25, 2026
Conversation
Co-authored-by: kpango <9798091+kpango@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix shard distribution bias due to key length and structure
Fix shard distribution bias: restore default expiration, add WithMaxKeyLength docs, and getShardID tests
Feb 25, 2026
kpango
approved these changes
Feb 25, 2026
kpango
added a commit
that referenced
this pull request
Feb 25, 2026
…eyLength docs, and getShardID tests (#150) * Initial plan * Restore default 30s expiration and add docs to WithMaxKeyLength Co-authored-by: kpango <9798091+kpango@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kpango <9798091+kpango@users.noreply.github.com> Signed-off-by: kpango <kpango@vdaas.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shard ID computation had a logic bug when
maxKeyLength=0(hashed empty string instead of full key), the 30s default expiration was silently dropped fromNew[V](), and the newWithMaxKeyLengthoption lacked documentation.Changes
New[V]()now appliesWithDefaultExpiration[V](30 * time.Second)alongsideWithMaxKeyLength[V](256)— its removal was an unintended breaking changegetShardIDlogic: normalizekl=0to use the full key length before branching; clampkltomin(len(key), kl)consistently across both pathsWithMaxKeyLength: clarifies the 256-byte default, the maphash/xxh3 selection threshold (≤32 bytes vs longer), and the meaning ofkl=0getShardIDunit tests: covers all behavioral boundaries —kl=0,kl=1,kl∈[2,32],kl>32, key shorter thankl, prefix isolation, and result range invariants💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.