Skip to content

Fix shard distribution bias: restore default expiration, add WithMaxKeyLength docs, and getShardID tests #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpango merged 2 commits into from
Feb 25, 2026
Merged

Fix shard distribution bias: restore default expiration, add WithMaxKeyLength docs, and getShardID tests #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ca59b
Initial plan
Copilot Feb 25, 2026
24ac775
Restore default 30s expiration and add docs to WithMaxKeyLength
Copilot Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ var hashSeed = maphash.MakeSeed()
func New[V any](opts ...Option[V]) Gache[V] {
g := new(gache[V])
for _, opt := range append([]Option[V]{
WithDefaultExpiration[V](30 * time.Second),
WithMaxKeyLength[V](256),
}, opts...) {
opt(g)
Expand Down
4 changes: 4 additions & 0 deletions option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ func WithExpiredHookFunc[V any](f func(ctx context.Context, key string, v V)) Op
}
}

// WithMaxKeyLength sets the maximum number of bytes used from each key when
// computing the shard ID. Keys up to 32 bytes use maphash for hashing; longer
// keys use xxh3. A value of 0 means the full key is always used. The default
// is 256 bytes.
func WithMaxKeyLength[V any](kl uint64) Option[V] {
return func(g *gache[V]) error {
g.maxKeyLength = kl
Expand Down