feat: add hardened scout implementation contract#628
Open
elixlabssolutions wants to merge 3 commits into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Implement the Firstmate hardened scout-to-implementation contract as a three-file, instruction-only change. Add one internal skill as the single full owner of proportional snapshot evidence, classified claims, readiness scoring, scope and behavior contracts, tests, delivery choreography, independent implementation packets, hard stops, quality gates, model-fit limits, and claim-keyed feedback. Add only the exact one-line section 13 trigger to AGENTS.md and one executable static contract test using tests/lib.sh. Preserve existing generic scout lifecycle and scratch teardown, do not add runtime enforcement or invent a work-order mechanism, do not touch any fourth tracked path, and preserve captain-only merge authority. The implementation was serialized after overlapping PR 619 merged, rebased onto exact refreshed origin/main fcb9e8a, and must retain exact three-path parity through all pipeline fixes.
What Changed
AGENTS.mdfor implementation-shaping scout work and subsequent dispatch or promotion.Risk Assessment
✅ Low: The change is confined to the required three instruction/test paths, preserves captain-only merge authority and existing scout lifecycle language, and adds no runtime enforcement or new work-order mechanism.
Testing
The supplied full-suite baseline had succeeded; I reran the focused static contract test and manually exercised the Markdown instruction surface from AGENTS trigger through the self-contained packet, capturing a CLI transcript because this is an instruction-only change with no rendered UI. All checks passed and the worktree remains clean.
Evidence: End-to-end instruction-surface verification transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"Baseline already provided as successful:command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"bash tests/fm-scout-implementation-contract.test.shManual end-to-end instruction-surface walkthrough recorded inscout-implementation-contract-e2e-transcript.txt: verified base ancestry, exact AGENTS loader trigger, loaded ownership/authority boundary, rendered packet template, exact three changed paths, contract exercise, and patch whitespace.git diff --check fcb9e8a5f2668e77fea86be5013bc3f218a01008 b5403660fd7a0e2c5d7ea1bab43773745dc59ddb🔧 **Document** - 1 issue found → auto-fixed ✅
tests/fm-scout-implementation-contract.test.sh:121- The required static contract test does not protect the no-runtime-enforcement, captain-only merge, or full lifecycle/scratch-teardown guarantees; expanding it would require a test edit outside the documentation-only scope.🔧 Fix: Protect scout contract safety boundaries
✅ Re-checked - no issues remain.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.